Repository navigation
fix(console): stop losing the manifest and name the SDL mistake - #16
Merged
Merged
Conversation
Two ways to end up with a lease that never gets a workload, both quiet. `deployment create` without an active context threw the manifest away and said to pass --manifest to `lease create`. Console returns that manifest exactly once, at create, so there was nothing left to pass: the deployment could be leased and then sat there with no workload, burning escrow, with `console status` answering 404. Emit the manifest in the result whenever it could not be cached, so the instruction is followable. `lease create --manifest` posted whatever bytes it was given. Passing the SDL is the obvious mistake -- same file, same directory -- and Console answers "invalid character '-' in numeric literal", its JSON parser hitting the leading `---`. Nothing in that names the cause. Check the file is JSON first and say what the flag actually wants. Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
troian
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways to end up with a lease that never gets a workload, both silent. Found while deploying a live multi-service workload to test
console events.1.
deployment createwithout a context threw the manifest awayIt printed
manifest not cached (no active context); pass --manifest to lease create— but Console returns that manifest exactly once, at create, so there was nothing left to pass.Real consequence, hit during testing: the deployment leased fine, then sat with an active lease and no workload, burning escrow, with
console statusanswering 404.Now the manifest is included in the result whenever it could not be cached, so the instruction is actually followable.
2.
lease create --manifestposted whatever bytes it gotPassing the SDL is the obvious mistake — same file, same directory. Console replies:
That's its JSON parser hitting the leading
---of the YAML. Nothing in it names the cause. Now checked locally:Fails before the API call rather than after.
Verified