Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119.
eofsAsCovariance()unweights a view of the solver's stored data in place, so each call divides the data by its weights again. Repeating the same query can therefore return a different map:Copy the data view when weights are present before dividing it. This preserves the first query's result and leaves the unweighted path unchanged. Add repeated-query checks for all three PC scalings to the existing solver-interface tests.
The configured suite passes with Iris, xarray and Dask on Python 3.12. It also passes on Python 3.8, with the unavailable optional Iris cases skipped. The configured pre-commit checks pass. Repeated queries on both bundled height/SST examples match independent covariance products; first-query results, complete unweighted controls and output metadata remain exact.