Skip to content

fix(source-zendesk-support): skip inaccessible side conversation tickets - #84404

Draft
Sanket Agarwal (snktagarwal) wants to merge 5 commits into
airbytehq:masterfrom
snktagarwal:codex/zendesk-side-conversations-403
Draft

fix(source-zendesk-support): skip inaccessible side conversation tickets#84404
Sanket Agarwal (snktagarwal) wants to merge 5 commits into
airbytehq:masterfrom
snktagarwal:codex/zendesk-side-conversations-403

Conversation

@snktagarwal

Copy link
Copy Markdown

Summary

  • treat per-ticket HTTP 403 responses from Zendesk side-conversation endpoints as inaccessible records and continue syncing
  • preserve records from accessible tickets instead of failing the whole stream
  • add regression coverage for 403 handling

Verification

  • uvx --from ruff==0.8.3 ruff check --select=I unit_tests/mock_server/test_side_conversations.py
  • uvx --from ruff==0.8.3 ruff format --check unit_tests/mock_server/test_side_conversations.py
  • TZ=UTC poetry run pytest -q mock_server/test_side_conversations.py (8 passed)
  • full connector unit suite previously passed (218 tests)
  • deployed GKE validation job emitted and committed equal record counts

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@octavia-bot

octavia-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Note

📝 PR Converted to Draft

More info...

Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy.

As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page.

To skip draft status in future PRs, please include [ready] in your PR title or add the skip-draft-status label when creating your PR.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from snktagarwal/airbyte-upstream! We're excited to have you in the Airbyte community.

If you have any questions, feel free to ask in the PR comments or join our Slack community.

💡 Show Tips and Tricks

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • /ai-review - AI-powered PR review for connector safety and quality gates.
  • /ai-docs-review - AI-powered documentation review for PRs with connector changes.
  • /ai-create-docs-pr - Creates a documentation PR for connector changes.
  • /force-merge reason="<A_GOOD_REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@snktagarwal

Copy link
Copy Markdown
Author

/run-connector-tests

@snktagarwal

Copy link
Copy Markdown
Author

All contributor-actionable checks are green, and local verification passes (218 passed). The unprivileged fork test fails only because secrets/config.json and secrets/config_oauth.json are unavailable; /run-connector-tests was attempted but requires repository write permission. The progressive-rollout check likewise lacks GCP_PROD_DB_ACCESS_CREDENTIALS on fork runs.

Maintainer action requested: please run the privileged connector tests and approve/rerun the progressive-rollout gate.

Production validation on our self-managed GKE deployment: custom image digest sha256:da38cc95a1fe60b12fe9d634919d52a736964f4e8d4aca826f4a3fa08d54f85a; six consecutive Airbyte syncs succeeded after deployment; latest run emitted/committed 1,783 records with 0 rejected; latest Dagster compat run passed 12/12 models.

@airbyte-support-bot

Copy link
Copy Markdown
Contributor

💬 Duplicate detected per Hands-Free AI Triage Project triage.

Thanks for the contribution! This change targets the same source-zendesk-support side_conversations 403 failure as an existing PR that is already further along the pipeline — it has regression results against published 5.5.1 across all 41 streams and a preview build (5.5.2-preview.32a0478) that a maintainer has pinned for a live customer connection:

To avoid two competing version bumps to 5.5.2, AI triage automation is advancing that PR only, and is taking no automated action here. If your version handles a case the other PR misses, please note it on that PR so the reviewer can fold it in.

Devin session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants