docs(destination-chroma): correct sync modes and document all config options - #84385
Draft
devin-ai-integration[bot] wants to merge 3 commits into
Draft
docs(destination-chroma): correct sync modes and document all config options#84385devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…ions Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering Context
Run triggered by: Automated
autodocrun for a connector commit merged tomaster.Relevant context: Source commit
16b8dfd(destination-chroma0.0.54 → 0.0.55, CDK bump for CVE-2025-68664), from #84361.Confidence impact: The trigger was a small, already-merged dependency PR with unambiguous scope, so the triggering context is clear and scores high.
Documentation Confidence Assessment
Overall Confidence: 3/5
metadata.yaml).Adjustments based on code comprehension
airbyte_cdk/destinations/vector_db_based(Writer,Embedder,DocumentProcessor), which is shared and separately documented; onlyindexer.pyis connector-specific.destination.py,indexer.py,config.py,utils.py,no_embedder.py; no dynamic dispatch or feature flags.unit_tests/test_indexer.pyasserts the collection-name rules and the/local/path prefix requirement that this PR documents.chromadb==0.6.3bound corroborates the name-length constraint.What I Verified vs. What I Inferred
indexer.py, CDKDocumentProcessor)._ab_streammatches the overwritten streams, rather than dropping the collection (ChromaIndexer.pre_sync/_delete_by_filter)._ab_record_idbefore writing (delete, CDKWriter).overwrite,append,append_dedupwithsupportsIncremental=True(destination.py), so the oldFull Refresh - Overwrite + Dedupedrow was wrong.destination.py)./local/path prefix check (utils.py,indexer.py,unit_tests/test_indexer.py)._get_client).NoEmbeddersendsNoneembeddings, so Chroma computes them.embedder.py).config.py,document_processor.py).all-MiniLM-L6-v2) running locally.Areas of Concern
/local→/tmp/airbyte_localmapping and macOS file-sharing guidance is rewritten from the previous docs and applies to Docker-based OSS deployments; a reviewer familiar with currentabctldeployments should confirm it is still accurate.Changelog validation
0.0.55links to[84361]→.../pull/84361(match). The version-bump commit16b8dfdlanded onmasteron 2026-08-13, which matches the changelog date. No changelog corrections were needed.What
Rewrites the user documentation for the Chroma destination so it matches the connector's actual behavior and documents the configuration options that were previously missing.
How
Corrections
Full Refresh - Overwrite + Dedupedsync mode row._ab_streammetadata value, not separate collections.Additions
_ab_streamand_ab_record_id.Formatting
MD060. No changelog rows or values were changed.Removals / restructuring
Review Guide
Verification
markdownlint-cli2) on the changed file: 0 errors.pnpm buildcould not run in this environment (node_modulesnot installed,docusaurus: not found). The CI docs build covers the same check and passed.User Impact
Readers get accurate sync-mode behavior, the metadata fields they need to filter on when querying Chroma, and documentation for configuration options that previously had none.
Can this PR be safely reverted and rolled back?
Devin session