docs(destination-astra): document setup, storage model, and limits - #84384
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
docs(destination-astra): document setup, storage model, and limits#84384devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering Context
Run triggered by: Automated docs review of a commit merged to
master—fix(destination-astra): bump CDK to remediate CVE-2025-68664 in langchain(version 0.1.45).Relevant context: #84359 (commit
4e2b4e99a6a7cbcee101a12b5573a7401c05fdad)Confidence impact: The trigger is a small, already-merged dependency bump with unambiguous scope, so the triggering context itself introduces no uncertainty; the uncertainty in this PR comes from the broader doc gaps I chose to fix, not from the trigger.
Documentation Confidence Assessment
Overall Confidence: 3/5
config.py,destination.py,indexer.py,astra_client.py) plus the shared vector-db CDK writer and document processor; the documented path has no custom components beyond a thin HTTP client.metadata.yamlpoint at olderastra-serverlesspaths.destination-astrais a community, alpha-stage connector with noab_internalquality/support levels set.Adjustments based on code comprehension
Baseline 3 (Python CDK), adjusted to 4:
integration_tests/spec.jsonanddestination_astra/config.py, not from imperative code.airbyte_cdk.destinations.vector_db_basedpackage; the connector-specific code isAstraIndexerplus a smallAstraClientthat issues Data API commands, both of which I read end to end.x-cassandra-tokenauth in the code line up with the DataStax Data API docs forcreateCollectionand application tokens.What I Verified vs. What I Inferred
find_collectionreturns false; collections are created with the cosine metric and the embedder's dimension; documents carry_id(a UUID),$vector,text(unless Do not store raw text is set),_ab_stream,_ab_record_id, and the configured metadata fields; overwrite deletes only documents matching_ab_streamfor the synced stream; deduplication deletes by_ab_record_id; all streams share one collection and the namespace is folded into_ab_stream; the five embedding modes and that OpenAI-compatible requires an explicitdimensionsvalue; supported sync modes come fromspec().default_keyspaceexists on new Serverless (Vector) databases; the 4,096-dimension ceiling, approximately 10 collections per database, the 64-field-per-collection limit, and the 8,000-byte indexed string limit; collections created without anindexingclause index every field.Areas of Concern
Pre-Requisitesline that listed only an embedding API key. The new list is longer; confirm nothing you consider essential dropped out.What
The Astra DB destination doc explained how to create an Astra database and where to copy the endpoint and token, and nothing else. It didn't say what the connector writes, which token permissions it needs, that it creates the collection for you, how each sync mode behaves, or which Astra limits you can run into. Anyone setting the connector up had to read the connector source to answer basic operational questions.
This PR fills those gaps and corrects the prerequisites, which previously listed an embedding API key as the only requirement.
How
Corrections
Pre-Requisiteslist with the connector's actual requirements: a Serverless (Vector) database and endpoint, an application token that can create collections and read and write in the keyspace, a keyspace, a collection name, and an embedding API key (not required for the Fake embedder).#38181/#37405changelog entries into links matching the format of the rest of the table.Additions
_id,$vector,text,_ab_stream,_ab_record_id, metadata fields), and that all streams share one collection._ab_streamrather than creating a keyspace or collection.Restructuring
##headings (the doc previously jumped from##to####), and converted the setup steps to numbered lists with real sub-steps instead of--prefixed lines.astra_db_endpoint,astra_db_app_token).Changelog validation
Review Guide
docs/integrations/destinations/astra.mdlines 7–13 (prerequisites) — the token permission claim is the one most likely to trip a user up if it's wrong.destination_astra/indexer.py::indexand the CDK'sdocument_processor.py.indexer.py::pre_syncandindexer.py::delete.User Impact
You can set up the Astra destination and predict what it writes without reading the connector source. No connector behavior changes.
Can this PR be safely reverted and rolled back?
Devin session