Skip to content

Add note to Whitespace section on removing trailing whitespace. - #163

Draft
unkillbob wants to merge 1 commit into
airbnb:masterfrom
orionhealth:remove-trailing-whitespace
Draft

Add note to Whitespace section on removing trailing whitespace.#163
unkillbob wants to merge 1 commit into
airbnb:masterfrom
orionhealth:remove-trailing-whitespace

Conversation

@unkillbob

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread README.md

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good call. It would be the most excellent if we could also include guides on how to set up automatic trailing space removal in various IDEs/text editors.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need go fmt for JS

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools exist although they're not as comprehensive:

https://github.com/jshint/fixmyjs
https://github.com/millermedeiros/esformatter

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sublime Text has the trim_trailing_white_space_on_save setting for this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sublime is
Preferences / Settings - User" to add the following:
{ "trim_trailing_white_space_on_save": true }

IntelliJ under preferences, editor
https://i.imgur.com/JDKfldN.png

JSCS has autofix (jscs src --fix) as of 1.12 and working on applying it to all rules.

@christophehurpeau

Copy link
Copy Markdown
Contributor

👍

@ljharb

ljharb commented Dec 23, 2015

Copy link
Copy Markdown
Collaborator

@unkillbob it'd be great to land this PR - would you rebase it on top of the latest master, and add a new subsection under "Whitespace" that links to this section? In addition, could you link to the eslint rule for this?

@ljharb ljharb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased this as an example in the now-existing trailing whitespace section

@ljharb

ljharb commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

@unkillbob actually, since you made this PR from a fork you don't own, you'd need to add me to the orionhealth repo for me to be able to land this.

@ljharb
ljharb marked this pull request as draft April 16, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants