Skip to content

fix(notebook): clarify viewImage execution paths - #1222

Merged
ewen-poch merged 1 commit into
mainfrom
fix/notebook-view-image-path-handoff
Aug 15, 2026
Merged

fix(notebook): clarify viewImage execution paths#1222
ewen-poch merged 1 commit into
mainfrom
fix/notebook-view-image-path-handoff

Conversation

@ewen-poch

@ewen-poch ewen-poch commented Aug 14, 2026

Copy link
Copy Markdown
Member

Problem

host.viewImage({ path }) resolves a generated file relative to the shared execution workspace used by Python, R, and REPL. The control capability called that root workspaceCwd, even though the Agent-facing Notebook MCP already uses workspaceCwd for the durable Session cwd.

That naming collision led the previous revision of this PR to bind the capability to notebookSessionRoot. The change made data/... happen to resolve, but also widened path authority to application-owned siblings such as handoff, run.json, caches, and Frame storage.

Proposed change

  • keep the control capability scoped to the shared execution dataRoot
  • rename the internal control binding from workspaceCwd to executionCwd
  • keep the public host.viewImage JavaScript contract camelCase and unchanged
  • describe { path } generically as relative to the current execution workspace, using the same relative path used to save a generated file
  • verify code-relative paths succeed while application-owned sibling paths remain rejected

Scope and non-goals

  • no data/... or handoff/... magic-prefix resolution
  • no ambient access to notebookSessionRoot
  • no change to explicit OPEN_SCIENCE_HANDOFF_DIR cross-kernel transfer
  • no change to Artifact or Upload { versionId } resolution
  • no new status or enum values
  • no database, schema, run.json, or other persisted-data changes
  • no historical-data migration or compatibility path required

Acceptance criteria and validation

Checks run after the final rebase onto origin/main (16ea4829, v0.15.1):

  • execution path authority and focused consumers -> npm test -- src/main/notebook/host-view-image-service.test.ts src/main/notebook/runtime-service.test.ts src/main/notebook/local-rpc-server.test.ts src/main/notebook/local-rpc-server.capabilities.test.ts src/main/notebook/session-aggregate.test.ts src/main/notebook/e2e.certification.test.ts src/main/host-sdk/help.test.ts src/main/skills/self-awareness-skill.test.ts src/main/runtime-electron-wiring.test.ts -> 8 files passed, 308 tests passed; one environment-gated file skipped (9 tests)
  • Node process type safety -> npm run typecheck:node -> passed
  • lint -> npm run lint -> 0 errors; 17 pre-existing Prettier warnings
  • patch hygiene -> git diff --check origin/main...HEAD -> passed
  • independent Standards review -> no findings
  • independent Spec review -> no findings

The impact classifier selects the full suite because resources/skills/self-awareness/SKILL.md has no declared module owner. Per maintainer request, the complete local npm test suite was not run; exact-head PR CI is authoritative for the complete and platform lanes.

Review focus

Please verify that the control capability receives executionCwd = dataRoot for both root and delegated lanes, while the Agent-facing Notebook MCP retains its separate durable Session workspaceCwd meaning.

@github-actions github-actions Bot added the bug Something isn't working label Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: No concrete merge-blocking defects found in the pull request changes. Branch and pull request title checks are valid.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 14, 2026
@ewen-poch
ewen-poch force-pushed the fix/notebook-view-image-path-handoff branch from 8013dfc to efee3cb Compare August 14, 2026 13:29
@github-actions github-actions Bot removed the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 14, 2026
@ewen-poch ewen-poch changed the title fix(notebook): unify viewImage file references fix(notebook): use Session root for viewImage paths Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: The change is consistent with the notebook session-root and host-image path contract. No concrete merge-blocking defect was found. Static inspection only; no tests or project commands were run.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 14, 2026
@ewen-poch
ewen-poch marked this pull request as ready for review August 14, 2026 16:11
@ewen-poch
ewen-poch force-pushed the fix/notebook-view-image-path-handoff branch from efee3cb to fe6a72e Compare August 14, 2026 16:11
@github-actions github-actions Bot removed the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defect in the pull request changes.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 14, 2026
@ewen-poch
ewen-poch force-pushed the fix/notebook-view-image-path-handoff branch from fe6a72e to 2d24adb Compare August 15, 2026 13:05
@github-actions github-actions Bot removed the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 15, 2026
@ewen-poch ewen-poch changed the title fix(notebook): use Session root for viewImage paths fix(notebook): clarify viewImage execution paths Aug 15, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defect introduced by this pull request.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 15, 2026
Keep host.viewImage scoped to the shared execution cwd and distinguish that capability from the durable Session workspace. Guide callers to reuse the relative path used when saving a generated file.
@ewen-poch
ewen-poch force-pushed the fix/notebook-view-image-path-handoff branch from 2d24adb to f1174c5 Compare August 15, 2026 13:13
@github-actions github-actions Bot removed the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 15, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defect introduced by this pull request. Branch and title checks are valid.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 15, 2026
@ewen-poch
ewen-poch merged commit a5da4a5 into main Aug 15, 2026
25 checks passed
@ewen-poch
ewen-poch deleted the fix/notebook-view-image-path-handoff branch August 15, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-to-merge All completed AI reviewers found this pull request mergeable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant