fix(harness): clarify skill shell path handling - #3026
Open
ZHCHJ888 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.3-SNAPSHOT
Description
Fixes #2788.
Skill execution guidance previously referred to a non-existent
execute_shell_commandtool and could lead agents to pass an absolute<files-root>path asworking_directory. However,working_directoryintentionally accepts only workspace-relative paths, so this caused skill script execution to be rejected.This PR:
executetool name in the generated skill prompt.command, whileworking_directorymust remain workspace-relative or be omitted.How to test:
Local results: 34 targeted tests passed. The clean Harness verification passed 989 tests with 6 environment-dependent tests skipped on Windows (5 Windows-disabled shell integration tests and 1 POSIX-permissions assumption).
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)