fix(controller): allow clearing Manager model provider - #1232
Merged
shiyiyue1102 merged 1 commit intoSep 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modelProviderupdate from an explicitly empty valuespec.modelProviderbindingagt update manager --model-provider, including--model-provider=for recoveryContext
When a Manager has switched to a model from a newly added provider and that provider or route is later removed, the persisted provider binding cannot currently be cleared through the update API. The Manager continues reconciling/requesting against the unavailable provider after restart, leaving reinstall as the apparent recovery path.
This change makes the recovery operation explicit:
The pointer field in
UpdateManagerRequestpreserves PATCH semantics: an omitted field remains unchanged, while an explicitly empty value clears the binding.The original report also says adding the provider causes an immediate chat error. It does not include the version, deployment mode, exact error, or logs, so this PR addresses the confirmed persistent recovery defect without claiming a cause for that separate initial failure.
Verification
origin/main(eeaab643)go test ./...fromagentteams-controller— passedgit diff --check origin/main...HEAD— passedRelated to #1224
Summary
modelProviderupdate from an explicitly empty valuespec.modelProviderbindingagt update manager --model-provider, including--model-provider=for recoveryContext
When a Manager has switched to a model from a newly added provider and that provider or route is later removed, the persisted provider binding cannot currently be cleared through the update API. The Manager continues reconciling/requesting against the unavailable provider after restart, leaving reinstall as the apparent recovery path.
This change makes the recovery operation explicit:
The pointer field in
UpdateManagerRequestpreserves PATCH semantics: an omitted field remains unchanged, while an explicitly empty value clears the binding.The original report also says adding the provider causes an immediate chat error. It does not include the version, deployment mode, exact error, or logs, so this PR addresses the confirmed persistent recovery defect without claiming a cause for that separate initial failure.
Verification
origin/main(eeaab643)go test ./...fromagentteams-controller— passedgit diff --check origin/main...HEAD— passedRelated to #1224