Skip to content

fix(initializer): use static service source for IP-based openai-compat base URLs #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaodingjiang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(initializer): use static service source for IP-based openai-compat base URLs #1171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions agentteams-controller/internal/initializer/initializer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package initializer
import (
"context"
"fmt"
"net"
"net/url"
"strconv"
"strings"
Expand Down Expand Up @@ -340,15 +341,27 @@ func (i *Initializer) initGatewayRoutes(ctx context.Context) error {
if strings.HasPrefix(cfg.OpenAIBaseURL, "http://") {
proto = "http"
}
if err := i.Gateway.EnsureServiceSource(ctx, "openai-compat", host, port, proto); err != nil {
logger.Error(err, "failed to register openai-compat service source (non-fatal)")
svcName := "openai-compat"

@oss-maintainer oss-maintainer Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests exist for initializer.go yet. The IP-vs-domain branching is easy to test in isolation — consider a table-driven test covering bare IPv4, bracketed IPv6, plain domain, domain with port, localhost, and empty host.

svcSuffix := "dns"
if net.ParseIP(host) != nil {

@oss-maintainer oss-maintainer Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto is computed but unused in the static branch: EnsureStaticServiceSource hardcodes protocol: "http" internally. An https:// base URL would silently register an http static source. Consistent with existing static-source usage (Tuwunel, Element Web), but worth a short comment or log line documenting the limitation.

// Bare IP addresses cannot be registered as DNS-type service sources
// (Higress console checkDomain rejects IPs, and Envoy DNS clusters
// cannot resolve them); use a static service source instead.
svcSuffix = "static"
if err := i.Gateway.EnsureStaticServiceSource(ctx, svcName, host, port); err != nil {
logger.Error(err, "failed to register openai-compat static service source (non-fatal)")
}
} else {
if err := i.Gateway.EnsureServiceSource(ctx, svcName, host, port, proto); err != nil {
logger.Error(err, "failed to register openai-compat service source (non-fatal)")
}
}
// Wait for DNS service source to propagate before creating provider
// Wait for service source to propagate before creating provider
time.Sleep(2 * time.Second)
raw := map[string]interface{}{
"agentteamsMode": true,
"openaiCustomUrl": cfg.OpenAIBaseURL,
"openaiCustomServiceName": "openai-compat.dns",
"openaiCustomServiceName": svcName + "." + svcSuffix,
"openaiCustomServicePort": port,
}
if err := i.Gateway.EnsureAIProvider(ctx, gateway.AIProviderRequest{
Expand All @@ -375,14 +388,24 @@ func (i *Initializer) initGatewayRoutes(ctx context.Context) error {
if strings.HasPrefix(cfg.OpenAIBaseURL, "http://") {
proto = "http"
}
if err := i.Gateway.EnsureServiceSource(ctx, provider, host, port, proto); err != nil {
logger.Error(err, "failed to register service source for provider (non-fatal)")
svcSuffix := "dns"
if net.ParseIP(host) != nil {
// Bare IP addresses cannot be registered as DNS-type service sources;
// use a static service source instead.
svcSuffix = "static"
if err := i.Gateway.EnsureStaticServiceSource(ctx, provider, host, port); err != nil {
logger.Error(err, "failed to register static service source for provider (non-fatal)")
}
} else {
if err := i.Gateway.EnsureServiceSource(ctx, provider, host, port, proto); err != nil {
logger.Error(err, "failed to register service source for provider (non-fatal)")
}
}
time.Sleep(2 * time.Second)
raw := map[string]interface{}{
"agentteamsMode": true,
"openaiCustomUrl": cfg.OpenAIBaseURL,
"openaiCustomServiceName": provider + ".dns",
"openaiCustomServiceName": provider + "." + svcSuffix,
"openaiCustomServicePort": port,
}
if err := i.Gateway.EnsureAIProvider(ctx, gateway.AIProviderRequest{
Expand Down
Loading