Repository navigation
fix(redis): honor no_ack in manual stream reads - #3274
Merged
IvanKirpichnikov merged 2 commits intoOct 22, 2026
Merged
Conversation
github-actions
Bot
added
the
Redis
|
|
powersemmi
previously approved these changes
Oct 21, 2026
IvanKirpichnikov
requested changes
Oct 22, 2026
| @pytest.mark.asyncio() | ||
| @pytest.mark.parametrize("no_ack", (False, True)) | ||
| @pytest.mark.parametrize("iterate", (False, True)) | ||
| async def test_manual_stream_read_respects_no_ack( |
Collaborator
There was a problem hiding this comment.
Let’s move this test to tests/brokers/redis/test_consume.py and split it into 2 tests: the 1 will be anext(aiter(sub)), the second get_one
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @IvanKirpichnikov ! I've moved the tests into TestConsumeStream in test_consume.py and split them into separate get_one() and anext(aiter(sub)) tests, as suggested. Both retain coverage for no_ack=True and no_ack=False.
IvanKirpichnikov
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward StreamSub.no_ack to XREADGROUP in get_one() and asynchronous iteration. Without it, manual readers configured with no_ack=True still add entries to the consumer group pending list.
Type of change
Validation
Checklist
The existing documented behavior is preserved; no API changes are introduced.