Skip to content

fix(mqtt): import MQTT when only the OpenTelemetry API is installed #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borisalekseev merged 1 commit into from
Oct 9, 2026
Merged

fix(mqtt): import MQTT when only the OpenTelemetry API is installed #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion faststream/_internal/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def __get_pydantic_core_schema__(
opentelemetry: Any

try:
import opentelemetry
import opentelemetry.semconv
except ImportError:
opentelemetry = None
HAS_OPENTELEMETRY = False
Expand Down
26 changes: 26 additions & 0 deletions tests/brokers/mqtt/test_import_without_semconv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import subprocess
import sys

import pytest


@pytest.mark.mqtt()
def test_mqtt_config_imports_without_semantic_conventions() -> None:
completed = subprocess.run(
[
sys.executable,
"-c",
"""\
import sys
sys.modules["opentelemetry.semconv"] = None
import opentelemetry
from faststream.mqtt.broker.config import MQTTBrokerConfig
assert MQTTBrokerConfig is not None
""",
],
check=False,
capture_output=True,
text=True,
)

assert completed.returncode == 0, completed.stderr
Loading