Skip to content

fix: strip credentials from AsyncAPI specification URLs - #3239

Merged
IvanKirpichnikov merged 5 commits into
ag2ai:mainfrom
Vitaly312:fix/remove-credentials-from-asyncapi-docs
Sep 29, 2026
Merged

fix: strip credentials from AsyncAPI specification URLs#3239
IvanKirpichnikov merged 5 commits into
ag2ai:mainfrom
Vitaly312:fix/remove-credentials-from-asyncapi-docs

Conversation

@Vitaly312

@Vitaly312 Vitaly312 commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Currently empty specification_url leads to leaking credentials into the schema. This PR strips user credentials (username, password, tokens) from AsyncAPI specification URLs across all brokers where appropriate(RabbitMQ, NATS, Redis). So when specification_url is not explicitly provided it prevents leaking credentials into the publicly served AsyncAPI docs (/docs.json)

Type of change

  • Bug fix

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis

@Vitaly312 @claude
fix: strip credentials from AsyncAPI specification URLs
ff430bf 
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions github-actions Bot added NATS Issues related to `faststream.nats` module and NATS broker features Redis Issues related to `faststream.redis` module and Redis features labels Sep 25, 2026
@Vitaly312
Vitaly312 marked this pull request as draft September 25, 2026 17:10
Vitaly312 and others added 2 commits September 25, 2026 21:56
@Vitaly312
Vitaly312 marked this pull request as ready for review September 26, 2026 07:43
@IvanKirpichnikov
IvanKirpichnikov added this pull request to the merge queue Sep 29, 2026
Merged via the queue into ag2ai:main with commit 2137966 Sep 29, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanKirpichnikov IvanKirpichnikov IvanKirpichnikov approved these changes
@powersemmi powersemmi Awaiting requested review from powersemmi powersemmi is a code owner

Assignees

No one assigned

Labels

NATS Issues related to `faststream.nats` module and NATS broker features Redis Issues related to `faststream.redis` module and Redis features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vitaly312 @IvanKirpichnikov