Skip to content

Feature: Implementation of the AsyncContextManager interface for Application #3228 - #3233

Merged
IvanKirpichnikov merged 8 commits into
ag2ai:mainfrom
ProstoKiReal:main
Sep 30, 2026
Merged

Feature: Implementation of the AsyncContextManager interface for Application #3228#3233
IvanKirpichnikov merged 8 commits into
ag2ai:mainfrom
ProstoKiReal:main

Conversation

@ProstoKiReal

@ProstoKiReal ProstoKiReal commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Description

Add impl app context manager with some tests
Change app.start()/stop() calls in TestAPP

Fixes #3228

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis
  • I have included code examples to illustrate the modifications

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 24, 2026
@CLAassistant

CLAassistant commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

IvanKirpichnikov
IvanKirpichnikov reviewed Sep 25, 2026
View reviewed changes
Comment thread faststream/_internal/testing/app.py
Comment thread faststream/_internal/testing/app.py
Vitaly312
Vitaly312 reviewed Sep 29, 2026
View reviewed changes
Comment thread faststream/_internal/application.py Outdated
@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code AioKafka Issues related to `faststream.kafka` module NATS Issues related to `faststream.nats` module and NATS broker features Redis Issues related to `faststream.redis` module and Redis features labels Sep 29, 2026
@IvanKirpichnikov
IvanKirpichnikov added this pull request to the merge queue Sep 30, 2026
Merged via the queue into ag2ai:main with commit bfc69cc Sep 30, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanKirpichnikov IvanKirpichnikov IvanKirpichnikov approved these changes
@Sehat1137 Sehat1137 Awaiting requested review from Sehat1137 Sehat1137 is a code owner
@Lancetnik Lancetnik Awaiting requested review from Lancetnik Lancetnik is a code owner
@powersemmi powersemmi Awaiting requested review from powersemmi
+1 more reviewer
@Vitaly312 Vitaly312 Vitaly312 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AioKafka Issues related to `faststream.kafka` module documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code NATS Issues related to `faststream.nats` module and NATS broker features Redis Issues related to `faststream.redis` module and Redis features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Implementation of the AsyncContextManager interface for Application

4 participants

@ProstoKiReal @CLAassistant @IvanKirpichnikov @Vitaly312