Skip to content

fix: docs render if broker is set by set_broker - #2592

Merged
Sehat1137 merged 3 commits into
mainfrom
fix-2588
Oct 16, 2025
Merged

fix: docs render if broker is set by set_broker#2592
Sehat1137 merged 3 commits into
mainfrom
fix-2588

Conversation

@Sehat1137

@Sehat1137 Sehat1137 commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Fix asyncapi docs render if broker is set by method
  • Fix logging for 5XX

Fixes #2588

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis
  • I have included code examples to illustrate the modifications

@Sehat1137
Sehat1137 requested a review from Lancetnik as a code owner October 16, 2025 20:46
@Sehat1137
Sehat1137 requested a review from draincoder October 16, 2025 21:01
draincoder
draincoder reviewed Oct 16, 2025
View reviewed changes
Comment thread faststream/_internal/application.py
Comment thread faststream/asgi/handlers.py
@Sehat1137
Sehat1137 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 0bef1fd Oct 16, 2025
29 checks passed
@Sehat1137
Sehat1137 deleted the fix-2588 branch October 16, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@draincoder draincoder draincoder approved these changes
@borisalekseev borisalekseev borisalekseev approved these changes
@Lancetnik Lancetnik Awaiting requested review from Lancetnik Lancetnik is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: async api route returns 500 if broker is set by set_broker

3 participants

@Sehat1137 @draincoder @borisalekseev