Repository navigation
feat: task supervisor - #2408
Merged
Merged
Conversation
Contributor
Author
|
Hi, @Lancetnik! I've created a new PR. Also, I’ve noticed that the test "test_logging:test_duplicates_set_formatter" sometimes fails when running all tests together, but it passes when run separately. I guess the issue is related to capturing stdout. |
Sehat1137
self-requested a review
August 5, 2025 09:37
Sehat1137
reviewed
Aug 7, 2025
Collaborator
|
Hi, thank you. Please, rebase your changes with upstream/dev and run |
Contributor
Author
|
@Sehat1137 No errors from "just mypy" |
Sehat1137
reviewed
Aug 31, 2025
Collaborator
There was a problem hiding this comment.
@fil1n Hi, sorry for the long replies. GitHub doesn't send me any notifications. Can we move our communication somewhere to messenger?
btw my telegram: @smqwe12
If you prefer use different channel of communication, pls share for me. We ready merge this, but i have a few questions which we can quickly resolve
Sehat1137
previously approved these changes
Sep 7, 2025
Sehat1137
enabled auto-merge
September 7, 2025 22:20
Sehat1137
disabled auto-merge
September 7, 2025 22:20
Sehat1137
previously approved these changes
Sep 7, 2025
Sehat1137
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1656
Type of change
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.shMISC.
PR was tested using following snippet