Repository navigation
fix(eval): check final response in failure attribution - #3506
Merged
vvlrff merged 2 commits intoOct 26, 2026
Merged
Conversation
vvlrff
approved these changes
Oct 26, 2026
vvlrff
enabled auto-merge
October 26, 2026 17:31
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
failure_attribution()currently treats text in any model response as an answer. An agent can say "I will look that up.", encounter a tool failure, and finish with no answer, yet receivevalue="none"andfailed=False.Check the final
ModelResponseinstead, matching the evaluator's output projection. Interim text no longer hidestool_failureorno_answer; a run with a nonempty final response retains its existing mechanical-failure classification. The helper docstring now describes this behavior.Validation:
TestConfigfor model responses.git diff --checkpassed.Related issue number
Fixes #3505
Checks
AI assistance
OpenAI Codex assisted with investigation, reproduction, the implementation in
ag2/eval/scorers/attribution.py, regression tests intest/eval/scorers/test_attribution.py, and drafting the issue and PR description.