Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
area:docs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Since
openai3.37.0, a Decisions question'sinstructionsaccepts a list of parts (input_text,input_image,input_json) next to a plain string, so a question can carry an image or JSON of its own.OpenAIDecisionsConfigcould only send a joined string, so those parts could not reach the question.This adds
question_instructionsonOpenAIDecisionsConfig: a string or a sequence ofDecisionQuestionInputPart. When set, it takes the agent prompt's place as the question's instructions (opt-in; default behavior unchanged); the schema description is still appended — joined in the string case, as a trailinginput_textpart in the parts case.It moves the
ag2[openai]floor toopenai>=3.37.0for theDecisionQuestionInputParttypes, following ADR 0023 §5's precedent; the ADR is updated. If a floor bump is unwanted, ag2-local TypedDicts for the parts are the alternative — happy to switch if preferred.Related issue number
#3491
Checks
uv run pytest test/config/— 1271 passed, 1 skipped, 1 xfailedruff check/ruff format --checkon changed files — cleanuv lock --upgrade-package openai— only openai 3.27.0 → 3.37.0 changeddecision_models.mdxupdatedAI assistance
The code, tests, and docs in this PR were written with AI assistance (ZCode/GLM). I reviewed every line, ran the checks above, and can explain and revise the change in review.