|
catch_to_ss3 <- function(year, se = 0.01, season = 7, fleet=1, yld_rat = NULL){ |
@mkapur-noaa I'm leaning toward this type of function not being in afscdata, but placing it in afscassess.
Couple of reasons:
- The data query function should produce the same data for every assessment, if this gets implemented at the start then data format will start off different between different assessments,
- There is a
clean_catch function in afscassess, I think having a clean_catch_ss function or age_comp_ss, etc. would be a method for maintaining consistent code structures
Thoughts?
Edit: looking at this function further, I would strongly suggest not using this method to include/not include the proj catch data that produces the same output file name - it seems to inevitably get messed up in the plotting/report arenas
afscdata/R/utils.R
Line 222 in 54852be
@mkapur-noaa I'm leaning toward this type of function not being in
afscdata, but placing it inafscassess.Couple of reasons:
clean_catchfunction inafscassess, I think having aclean_catch_ssfunction orage_comp_ss, etc. would be a method for maintaining consistent code structuresThoughts?
Edit: looking at this function further, I would strongly suggest not using this method to include/not include the proj catch data that produces the same output file name - it seems to inevitably get messed up in the plotting/report arenas