Skip to content

Attempt to implement SolidBodyNearlyIncompressibleX - #640

Draft
adtzlr wants to merge 3 commits into
mainfrom
try2-solidbodynearlyincompressible-x
Draft

Attempt to implement SolidBodyNearlyIncompressibleX#640
adtzlr wants to merge 3 commits into
mainfrom
try2-solidbodynearlyincompressible-x

Conversation

@adtzlr

@adtzlr adtzlr commented Feb 20, 2024

Copy link
Copy Markdown
Owner
  • this works for disconnected dual meshes
  • but not for connected dual meshes

I guess it's because the volume-matrices are not invertible for connected meshes.

I'm not sure if it's worth the effort for disconnected meshes only...

@adtzlr adtzlr added the enhancement New feature or request label Feb 20, 2024
@adtzlr adtzlr self-assigned this Feb 20, 2024
@adtzlr
adtzlr marked this pull request as draft February 20, 2024 16:04
@codecov

codecov Bot commented Feb 20, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.85034% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.91%. Comparing base (3ecf1a3) to head (f64797b).
⚠️ Report is 1488 commits behind head on main.

Files with missing lines Patch % Lines
...rc/felupe/mechanics/_solidbody_incompressible_x.py 17.34% 81 Missing ⚠️
src/felupe/mechanics/_helpers.py 25.00% 27 Missing ⚠️
src/felupe/field/_dual.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   97.07%   94.91%   -2.17%     
==========================================
  Files          94       95       +1     
  Lines        4752     4896     +144     
==========================================
+ Hits         4613     4647      +34     
- Misses        139      249     +110     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adtzlr adtzlr mentioned this pull request Feb 20, 2024
6 tasks
@adtzlr adtzlr changed the title Second attempt for SolidBodyNearlyIncompressibleX Attempt to implement SolidBodyNearlyIncompressibleX Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant