Add keyboard shortcuts to color palette generator - #506
Draft
tabletalkstudio wants to merge 4 commits into
Draft
Conversation
Space generates a random palette; ArrowLeft/ArrowRight navigate back and forward through history. Shortcuts are suppressed when any interactive element has keyboard focus (inputs, buttons, links, color-wheel markers, ARIA role widgets) so keyboard-only users are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tabletalkstudio
force-pushed
the
keyboard-changes
branch
from
May 21, 2026 19:14
2c079fc to
5d236f4
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… color-extract - Move shared undo/redo keyboard listener into createColorToolLayout so color-blindness and color-contrast-checker get the shortcut automatically - Remove duplicate Cmd/Ctrl+Z branches from color-wheel (layout handles it now) - Add Cmd/Ctrl+Z to color-extract palette and gradient variants via historyManager Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tabletalkstudio
marked this pull request as draft
May 26, 2026 00:13
echen-adobe
reviewed
May 29, 2026
| function makeUndoRedoHandler(actionMenu) { | ||
| return (e) => { | ||
| if (!e.metaKey && !e.ctrlKey) return; | ||
| if (e.key !== 'z') return; |
Contributor
There was a problem hiding this comment.
I think something is broken with the undo / redo, if you generate 3 palettes, undo all of them, the redo combo no longer works. This could potentially fix that.
Suggested change
| if (e.key !== 'z') return; | |
| if (e.key.toLowerCase() !== 'z') return; |
echen-adobe
requested changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createActionMenuComponent.js— exposegenerateRandomon the returned API so the full generate-random sequence (color reset + history push) can be triggered without a button clickcolor-wheel.js— add akeydownlistener ondocumentwired toactionMenuApi.generateRandom,actionMenuApi.undo, andactionMenuApi.redo; listener is cleaned up on block re-init (breakpoint change)Jira Ticket
n/a
Test URLs
Verification Steps
Potential Regressions
Additional Notes
Test plan