ci(mwpw-00000): skip SonarQube analysis for Dependabot PRs - #601
Conversation
AI Code ReviewLast updated Aug 26, 2026 11:17 PM PDT · PR opened · commit 0 open · 0 resolved Open findingsNo open findings. ✅ Review history (1 run)
|
|
Agent QA review — interactive + visual diff (advisory, non-blocking)Last updated Aug 26, 2026, 11:22 PM PDT · PR opened · commit 0 open · 0 resolved · visual diff 0.00% · verdict PASS Open findings
What the agent checkedTested https://business.adobe.com/resources/main.html with the PR #601 CaaS build injected. Context: PR #601 is a pure CI workflow change (skips the SonarQube job for Dependabot PRs in .github/workflows/pull-request.yaml). It contains no frontend/CaaS code changes, which matches the provided pixel-diff result of 0.00% changed pixels. I loaded the diff.png as instructed and it showed no magenta/highlighted regions — consistent with a CI-only change that cannot affect page rendering. Manual verification performed on the live page anyway:
Since the code change is CI-only (workflow YAML), there is no plausible mechanism for it to alter the rendered page, and the observed 0.00% pixel diff plus my manual pass through search/filter/grid/pagination areas confirms the live resource center page is unaffected and functioning normally. Verdict: PASS — no regressions found; PR is safe to merge from a frontend/QA perspective (it only affects CI job execution, not the shipped CaaS bundle behavior). PR / stable / diff screenshots + console + axe artifacts in the workflow run. Review history (1 run)
|
🧪 Feature QA review — injected feature test (advisory, non-blocking)Last updated Aug 26, 2026, 11:23 PM PT · commit Overall: SKIPPED Not an injectable feature -- skipped.
This PR's change isn't driven by config/collection data the harness can force, and the build-output-diff verdict wasn't available to consult. (The visual/smoke review still applies.) Screenshot in the workflow run. Review history (1 run)
|

0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (91.00% Estimated after merge)
What
Skip the
sonarqubejob on Dependabot PRs, matching the existing skips oncheck-pr-titleandrun-bulk-publisher-e2e.Why
SonarQube analysis was added to the PR workflow in #584. Dependabot PRs that have since been rebased onto latest main pick up the job and fail it:
The job reads
${{ secrets.SONAR_TOKEN }}and${{ secrets.SONAR_HOST_URL }}. GitHub withholds repository secrets from Dependabot-triggered workflow runs, so both resolve to empty strings and the scanner exits 1.Two reasons to skip rather than plumb the secrets through:
package.jsonandpackage-lock.json. There is no first-party source for Sonar to analyse, so the scan has no value on these PRs.This is the same reasoning already recorded on
run-bulk-publisher-e2e: "Skip for Dependabot PRs — secrets are withheld by GitHub for Dependabot-triggered workflows."Scope
needs: sonarqube, so skipping it blocks no downstream job.merge.yamlSonar analysis onmainis untouched — every dependency change is still analysed once it lands.Affected PRs
#591, #592, #593, #594, #595 are all currently red on this check only. Their
review-score-gatealready auto-passes via the deps-dev +build-output-diff NO_CHANGEfast path.Note
Raised under
mwpw-00000as the PR-title linter requires a ticket scope — swap in a real ticket if you have one.