ci: bump build to Node 24 and run build-output-diff on all PRs - #578
ci: bump build to Node 24 and run build-output-diff on all PRs#578sanrai wants to merge 3 commits into
Conversation
AI Code ReviewLast updated Aug 14, 2026 11:04 PM PDT · new commit pushed · commit 0 open · 0 resolved Open findingsNo open findings. ✅ Review history (2 runs)
|
Agent QA review — interactive + visual diff (advisory, non-blocking)Last updated Aug 17, 2026, 9:54 PM PDT · new commit pushed · commit 0 open · 0 resolved · visual diff 0.00% · verdict PASS Open findings
What the agent checkedTested PR #578 against live business.adobe.com/resources/main.html (CaaS resource collection). Context: This PR only modifies two GitHub Actions workflow YAML files (CI configuration for build/test infra — bumping Node version to 24 and removing a paths filter on the advisory build-output-diff check). It contains zero application code changes. The pre-captured pixel diff of PR build vs stable build showed 0.00% pixel difference, and loading the diff image confirmed no magenta/highlighted regions anywhere — i.e., no visual delta was introduced by this PR, exactly as expected for a CI-only change. Manual QA performed on the live page to confirm the underlying app still works correctly (sanity check, since the diff showed no changes to verify against):
Conclusion: Since the changed files are purely CI workflow configuration (Node version bump for the build job + removing a paths filter so the advisory diff check runs on all PRs), there is no application code or rendering impact. This matches the observed 0.00% pixel diff. Live-page interaction (filters, search, card grid, pagination-adjacent controls) all function correctly with no visual or functional regressions found. The PR is safe to merge from a Feature QA / rendering perspective; it correctly reports "NO_CHANGE"-equivalent behavior as intended by its own description. PR / stable / diff screenshots + console + axe artifacts in the workflow run. Review history (3 runs)
|
🧪 Feature QA review — injected feature test (advisory, non-blocking)Last updated Aug 17, 2026, 9:55 PM PT · commit Overall: SAFE (no bundle change) No injectable feature to exercise — and the deterministic build-output-diff proves the shipped bundle is byte-identical to base after normalization, so this change is safe for what ships.
Screenshot in the workflow run. Review history (3 runs)
|
Isolated experiment: bumps ONLY the check-build job to Node 24 (all other jobs untouched) to confirm the app build runs on Node 24. A local test already showed node16 vs node24 produce byte-identical main.min.js. Note: check-pr-title will fail because the title has no mwpw JIRA scope, which is unrelated to the build.