Skip to content

ci: bump build to Node 24 and run build-output-diff on all PRs - #578

Open
sanrai wants to merge 3 commits into
mainfrom
node24-build-isolated-test
Open

ci: bump build to Node 24 and run build-output-diff on all PRs#578
sanrai wants to merge 3 commits into
mainfrom
node24-build-isolated-test

Conversation

@sanrai

@sanrai sanrai commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Isolated experiment: bumps ONLY the check-build job to Node 24 (all other jobs untouched) to confirm the app build runs on Node 24. A local test already showed node16 vs node24 produce byte-identical main.min.js. Note: check-pr-title will fail because the title has no mwpw JIRA scope, which is unrelated to the build.

@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

AI Code Review

Last updated Aug 14, 2026 11:04 PM PDT · new commit pushed · commit 4df16fd · 2 files changed in PR.

0 open · 0 resolved

Open findings

No open findings.

Review history (2 runs)
  • 4df16fd · Aug 14, 2026 11:04 PM PDT · new commit pushed · no changes (0 open) — ci: also run build-output-diff on all PRs (drop paths filter)
  • 7b490a8 · Aug 14, 2026 10:38 PM PDT · PR opened · no changes (0 open) — ci: run build check on Node 24 (isolated experiment)

@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

Agent QA review — interactive + visual diff (advisory, non-blocking)

Last updated Aug 17, 2026, 9:54 PM PDT · new commit pushed · commit c0735b0 · 2 files changed.

0 open · 0 resolved · visual diff 0.00% · verdict PASS

Open findings

  • Smoke test passed ✅
What the agent checked

Tested PR #578 against live business.adobe.com/resources/main.html (CaaS resource collection).

Context: This PR only modifies two GitHub Actions workflow YAML files (CI configuration for build/test infra — bumping Node version to 24 and removing a paths filter on the advisory build-output-diff check). It contains zero application code changes. The pre-captured pixel diff of PR build vs stable build showed 0.00% pixel difference, and loading the diff image confirmed no magenta/highlighted regions anywhere — i.e., no visual delta was introduced by this PR, exactly as expected for a CI-only change.

Manual QA performed on the live page to confirm the underlying app still works correctly (sanity check, since the diff showed no changes to verify against):

  1. Page load: Adobe for Business resource center loaded correctly, header nav, breadcrumb, hero heading "Explore all Adobe resources", and card grid all rendered cleanly with no layout issues.
  2. Filter panel (LeftFilters): Opened "Products" facet — expanded smoothly showing checkbox list (Acrobat, Acrobat Sign, Advertising, Analytics, etc.) with proper alignment and spacing.
  3. Applied "Acrobat" filter: Checkbox checked, "Acrobat ×" chip appeared under Search box, filter counter badge showed "1", results count updated from 3799 → 182, and the card grid refreshed to show Acrobat-relevant content (correct cards, images, titles, descriptions, "Read article" buttons all rendered properly, no truncation or overlap).
  4. Search box: Typed "creative" into the side search input without errors; input accepted text normally, clear (×) button present.
  5. Console errors: Only one unrelated message was observed — a browser permissions-policy warning about "unload" not being allowed, which is a generic browser-level notice unrelated to this PR's CI-only changes and not a rendering/JS regression.

Conclusion: Since the changed files are purely CI workflow configuration (Node version bump for the build job + removing a paths filter so the advisory diff check runs on all PRs), there is no application code or rendering impact. This matches the observed 0.00% pixel diff. Live-page interaction (filters, search, card grid, pagination-adjacent controls) all function correctly with no visual or functional regressions found. The PR is safe to merge from a Feature QA / rendering perspective; it correctly reports "NO_CHANGE"-equivalent behavior as intended by its own description.

PR / stable / diff screenshots + console + axe artifacts in the workflow run.

Review history (3 runs)
  • c0735b0 · Aug 17, 2026, 9:54 PM PDT · new commit pushed · passing, no regressions — Merge branch 'main' into node24-build-isolated-test
  • 4df16fd · Aug 14, 2026, 11:07 PM PDT · new commit pushed · passing, no regressions — ci: also run build-output-diff on all PRs (drop paths filter
  • 7b490a8 · Aug 14, 2026, 10:42 PM PDT · PR opened · passing, no regressions — ci: run build check on Node 24 (isolated experiment)

@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

🧪 Feature QA review — injected feature test (advisory, non-blocking)

Last updated Aug 17, 2026, 9:55 PM PT · commit a08ba0f · pull_request.

Overall: SAFE (no bundle change)

No injectable feature to exercise — and the deterministic build-output-diff proves the shipped bundle is byte-identical to base after normalization, so this change is safe for what ships.

This PR only changes CI workflow files (Node version bump and workflow trigger paths), with no config/card-data-driven UI behavior to exercise.

Screenshot in the workflow run.

Review history (3 runs)
  • Aug 17, 2026, 9:55 PM PT · SAFE (no bundle change) · a08ba0f · pull_request
  • Aug 14, 2026, 11:04 PM PT · SAFE (no bundle change) · 78c4305 · pull_request
  • Aug 14, 2026, 10:43 PM PT · SKIPPED · c749986 · pull_request

@sanrai sanrai changed the title ci: run build check on Node 24 (isolated experiment) ci: bump build to Node 24 and run build-output-diff on all PRs Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants