fix(frontend/analysis): handle comment filter being (un)applied - #1484
Open
c0rydoras wants to merge 1 commit into
Open
fix(frontend/analysis): handle comment filter being (un)applied#1484c0rydoras wants to merge 1 commit into
c0rydoras wants to merge 1 commit into
Conversation
c0rydoras
force-pushed
the
fix/frontend/analysis/index/report-comment-qp-bricolage
branch
from
August 14, 2026 07:08
375949a to
800b382
Compare
Because `ReportComment`'s `@onChange` is actually "on input", we update the comment query param on every keystroke. Fixing this properly would be a bigger thing 🙃, and is documented as a TODO.
c0rydoras
force-pushed
the
fix/frontend/analysis/index/report-comment-qp-bricolage
branch
from
August 14, 2026 08:09
800b382 to
9413565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
ReportComment's@onChangeis actually "on input", we update the comment query param on every keystroke. Fixing this properly would be a bigger thing 🙃, and is documented as a TODO.