Skip to content

docs(conformance): catalog creative vector sets - #6875

Closed
bokelley wants to merge 1 commit into
mainfrom
fix/conformance-vector-catalog
Closed

docs(conformance): catalog creative vector sets#6875
bokelley wants to merge 1 commit into
mainfrom
fix/conformance-vector-catalog

Conversation

@bokelley

@bokelley bokelley commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • catalog the two versioned creative vector sets added by feat(creative): add creative revision identity #6781
  • document their existing source and immutable-version CDN paths
  • refresh the catalog date
  • add an empty changeset because the catalog is classified as protocol release surface, while intentionally declaring no package bump

This is a documentation-only repair for the deterministic main-branch conformance freshness failure. It does not change schemas, vectors, protocol behavior, or conformance rules.

Verification

  • npm run test:doc-compliance-drift (20 freshness/compliance tests and release instrumentation passed)
  • npx changeset status --since=origin/main
  • git diff --check

@bokelley
bokelley force-pushed the fix/conformance-vector-catalog branch from 2ae814e to 7e4154f Compare August 25, 2026 11:40
| [`webhook-receiver-envelope`](https://github.com/adcontextprotocol/adcp/blob/main/static/compliance/source/test-vectors/webhook-receiver-envelope.json) | Receiver-side replay vectors for full MCP webhook POST envelopes: canonical delivery-report envelope acceptance, retry idempotency preservation, and rejection of bare result payloads or malformed envelopes | `static/compliance/source/test-vectors/webhook-receiver-envelope.json` | `/compliance/latest/test-vectors/webhook-receiver-envelope.json` |
| [`catalog-macro-substitution`](https://github.com/adcontextprotocol/adcp/blob/main/static/compliance/source/test-vectors/catalog-macro-substitution.json) | Catalog-item macro substitution safety: NFC normalization, RFC 3986 percent-encoding, nested-expansion preservation, CRLF neutralization, bidi override neutralization, and URL-scheme injection neutralization | `static/compliance/source/test-vectors/catalog-macro-substitution.json` | `/compliance/latest/test-vectors/catalog-macro-substitution.json` |
| [`universal-macro-translation`](https://github.com/adcontextprotocol/adcp/blob/main/static/compliance/source/test-vectors/universal-macro-translation.json) | Producer-side universal-macro translation: RFC 3986 unreserved-whitelist value encoding, verbatim native insertion, unmapped-macro param dropping, privacy/consent macro advisory, suspect native-value detection, single-pass substitution, and control-character rejection in native mappings | `static/compliance/source/test-vectors/universal-macro-translation.json` | `/compliance/latest/test-vectors/universal-macro-translation.json` |
| [`creative-representation-resolution`](https://github.com/adcontextprotocol/adcp/blob/main/static/compliance/source/test-vectors/creative-representation-resolution.json) | Deterministic creative-representation selection across product and seller capability intersections: paired redirects, highest-compatible VAST selection, representation-order tie breaking, retained alternatives, and exhaustive rejection output when no representation is compatible | `static/compliance/source/test-vectors/creative-representation-resolution.json` | `/compliance/latest/test-vectors/creative-representation-resolution.json` |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST FIX: No .changeset/*.md in this PR. docs/reference/** is protocol-scoped — check-changeset-protocol-scope.cjs matches /^docs\/reference\//, so the Changeset Check job runs changesets status and will not skip. Precedent: the two prior edits to this exact file each carried a changeset — #6807 (patch) and #4559 (empty notes-only). Add one (empty ---\n--- notes changeset matches #4559 for a catalog-freshness sync). Omitting it ships a docs/reference/ change untracked against the versioning surface: high.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Request changes

Request changes — 1 blocking finding.

Blocking findings

  • docs/reference/test-vectors/index.mdx:38 — docs/reference/ (protocol-scoped) change ships with no changeset. Per the repo's mandatory changeset-scope rule, a PR touching the published protocol surface (including normative reference docs under docs/reference/**) without a .changeset/*.md is high — it ships an untracked wire/spec change. Add an appropriate changeset (node scripts/check-changeset-protocol-scope.cjs origin/main is the gate; an empty changeset to satisfy CI is not the fix).

The rest of the PR checks out: both source vector files exist, row descriptions match their contents, and CDN paths follow the /compliance/latest/ column convention. The high-risk flag is only a (modified) docs match, not an escalation trigger. Row 1 of the decision table fires on the single high finding.

Blocking findings

  • docs/reference/test-vectors/index.mdx:38 — docs/reference/ (protocol-scoped) change ships with no changeset

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — documentation-only catalog repair with no blocking findings.

What I checked:

  • Diff touches only .changeset/catalog-creative-vector-sets.md and docs/reference/test-vectors/index.mdx (7 additions, 1 deletion).
  • The change catalogs two creative vector sets (creative-representation-resolution, macro-processing) already published under #6781 and refreshes the freshness date to 2026-08-25. Catalog descriptions and source paths are coherent with on-disk vector files.
  • Empty no-bump changeset correctly satisfies the protocol-scope gate for a docs/reference change that ships no new wire surface.
  • high_risk is true only because docs/reference/index.mdx is a (modified) match — no medium-or-higher finding on that file, so the modification is presumed safe. Row 5 does not fire (no medium finding).
  • gated_paths is false, so row 2 does not apply despite review_decision: REVIEW_REQUIRED.
  • No no-auto-approve team match; no prior decision.

No findings from the reviewer. Rows 1–8 do not fire → row 9 approve.

@bokelley
bokelley enabled auto-merge (squash) August 25, 2026 11:44
@bokelley
bokelley disabled auto-merge August 25, 2026 11:44
@bokelley
bokelley requested a review from pkras August 25, 2026 11:49
@bokelley
bokelley enabled auto-merge (squash) August 25, 2026 11:50
@bokelley

Copy link
Copy Markdown
Contributor Author

Superseded by #6874, which incorporated this exact reviewed catalog repair to unblock the Addie PR after the base-branch static failure. The repair is now merged to main in 772256f.

@bokelley bokelley closed this Aug 25, 2026
auto-merge was automatically disabled August 25, 2026 12:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant