Skip to content

docs: AAMP follow-ups — landscape entry, ARTF naming, snapshot drift watcher - #6805

Merged
bokelley merged 2 commits into
mainfrom
aamp-followups
Aug 23, 2026
Merged

docs: AAMP follow-ups — landscape entry, ARTF naming, snapshot drift watcher#6805
bokelley merged 2 commits into
mainfrom
aamp-followups

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Follow-ups from #6801:

  • industry-landscape.mdx now covers AAMP: added to IAB Tech Lab's key outputs and given a row in the ecosystem standards table pointing at the FAQ comparison, so the page the FAQ bills as "the full picture" no longer omits it.
  • ARTF naming aligned with IAB Tech Lab's current expansion (Agentic Real Time Framework) in the content-standards doc, and the GEO monitor's competitor patterns now match the current name alongside the older "Agentic RTB Framework".
  • Freshness mechanism for the dated comparison: the FAQ table and Addie's rules make dated absence claims ("no tagged specification release" as of 2026-08-23) that become false the day IAB publishes. A weekly workflow (aamp-snapshot-check.yml) compares the pinned snapshot in scripts/aamp-snapshot.json against the IABTechLab GitHub org and opens/updates a tracking issue on drift. Both the no-drift and drift paths were exercised against the live org (drift path via a deliberately wrong pinned tag).

🤖 Generated with Claude Code

…watcher

Adds AAMP to the industry-landscape standards tables, aligns the ARTF
expansion with IAB Tech Lab's current name (Agentic Real Time Framework),
teaches the GEO monitor the current name, and adds a weekly workflow that
compares the dated AAMP claims in the FAQ and Addie's rules against the
IABTechLab GitHub org, opening a tracking issue when the pinned snapshot
in scripts/aamp-snapshot.json drifts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread scripts/check-aamp-snapshot.cjs
Comment thread scripts/check-aamp-snapshot.cjs Outdated

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated path requires human/CODEOWNERS review.

This PR adds .github/workflows/aamp-snapshot-check.yml, which matches the deterministic hard approval gate on .github/workflows/** (gated_paths: true). Because review_decision is REVIEW_REQUIRED (not APPROVED), decision-table row 2 fires: this cannot auto-approve and must go to a human.

No blocking (critical/high) findings were reported. The change is a docs-and-tooling PR: corrects ARTF's expansion, adds an AAMP row to the industry-landscape tables, adds a geo-monitor regex, and introduces a weekly cron watching the IABTechLab org. No protocol surface (static/schemas/source/**, docs/reference/**) is touched, so no changeset is required — correct.

The high_risk flag is only a (modified) match on server/src/addie/jobs/geo-monitor.ts with no medium-or-higher finding on it, so row 5 does not apply on its own.

Medium findings (for the human reviewer, non-blocking):

  • scripts/check-aamp-snapshot.cjs:29 — gh() conflates a 404 (repo not yet created) with a fatal check failure
  • scripts/check-aamp-snapshot.cjs:49 — expectLatestTag relies on tags[0] being the newest tag

Escalation reason: touches gated path .github/workflows/aamp-snapshot-check.yml; requires human/CODEOWNERS approval (review_decision is REVIEW_REQUIRED).

Medium findings

  • scripts/check-aamp-snapshot.cjs:29 — gh() conflates 404 (repo not yet created) with a fatal check failure
  • scripts/check-aamp-snapshot.cjs:49 — expectLatestTag relies on tags[0] being the newest tag

Why human review

  • Adds gated path .github/workflows/aamp-snapshot-check.yml (matches .github/workflows/**) and review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required before merge.
  • This PR touches a path under a hard, non-overridable approval gate (.github/workflows/aamp-snapshot-check.yml (added) matches .github/workflows/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.

@aao-secretariat aao-secretariat Bot added the ladon/needs-human-review Ladon has escalated this PR for human review. label Aug 23, 2026
…lerant

Compare the tag set to the expected tag instead of trusting list order,
and report a missing repo as drift (renamed/removed changes the org
shape) rather than failing the run.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated path requires human/CODEOWNERS approval.

This PR adds .github/workflows/aamp-snapshot-check.yml, which matches the .github/workflows/** gated-path glob (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so the hard approval gate (decision-table row 2) is not satisfied and the PR cannot auto-approve regardless of how clean the diff is.

Iteration credit: both prior Medium findings in scripts/check-aamp-snapshot.cjs were resolved. gh() now returns null on 404 so a not-yet-created repo is reported as drift rather than crashing, and expectLatestTag now fetches per_page=100 and compares the full tag set instead of trusting tags[0] to be newest. No new findings in the delta. The escalation is purely the standing gated-path gate, not any code concern.

Resolution: a human/CODEOWNERS approval on the workflow file will lift the gate and let a subsequent review fall through to a normal (likely approve) outcome.

Escalation reasons

  • Adds .github/workflows/aamp-snapshot-check.yml (matches .github/workflows/**) under a hard, non-overridable approval gate; review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required before merge.

Why human review

  • Adds gated path .github/workflows/aamp-snapshot-check.yml (matches .github/workflows/**) and review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required before merge.
  • This PR touches a path under a hard, non-overridable approval gate (.github/workflows/aamp-snapshot-check.yml (added) matches .github/workflows/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.

@bokelley
bokelley merged commit 3d38505 into main Aug 23, 2026
34 checks passed
@bokelley
bokelley deleted the aamp-followups branch August 23, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ladon/needs-human-review Ladon has escalated this PR for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant