docs: AAMP follow-ups — landscape entry, ARTF naming, snapshot drift watcher - #6805
Conversation
…watcher Adds AAMP to the industry-landscape standards tables, aligns the ARTF expansion with IAB Tech Lab's current name (Agentic Real Time Framework), teaches the GEO monitor the current name, and adds a weekly workflow that compares the dated AAMP claims in the FAQ and Addie's rules against the IABTechLab GitHub org, opening a tracking issue when the pinned snapshot in scripts/aamp-snapshot.json drifts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated path requires human/CODEOWNERS review.
This PR adds .github/workflows/aamp-snapshot-check.yml, which matches the deterministic hard approval gate on .github/workflows/** (gated_paths: true). Because review_decision is REVIEW_REQUIRED (not APPROVED), decision-table row 2 fires: this cannot auto-approve and must go to a human.
No blocking (critical/high) findings were reported. The change is a docs-and-tooling PR: corrects ARTF's expansion, adds an AAMP row to the industry-landscape tables, adds a geo-monitor regex, and introduces a weekly cron watching the IABTechLab org. No protocol surface (static/schemas/source/**, docs/reference/**) is touched, so no changeset is required — correct.
The high_risk flag is only a (modified) match on server/src/addie/jobs/geo-monitor.ts with no medium-or-higher finding on it, so row 5 does not apply on its own.
Medium findings (for the human reviewer, non-blocking):
- scripts/check-aamp-snapshot.cjs:29 — gh() conflates a 404 (repo not yet created) with a fatal check failure
- scripts/check-aamp-snapshot.cjs:49 — expectLatestTag relies on tags[0] being the newest tag
Escalation reason: touches gated path .github/workflows/aamp-snapshot-check.yml; requires human/CODEOWNERS approval (review_decision is REVIEW_REQUIRED).
Medium findings
- scripts/check-aamp-snapshot.cjs:29 — gh() conflates 404 (repo not yet created) with a fatal check failure
- scripts/check-aamp-snapshot.cjs:49 — expectLatestTag relies on tags[0] being the newest tag
Why human review
- Adds gated path .github/workflows/aamp-snapshot-check.yml (matches .github/workflows/**) and review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required before merge.
- This PR touches a path under a hard, non-overridable approval gate (.github/workflows/aamp-snapshot-check.yml (added) matches
.github/workflows/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
…lerant Compare the tag set to the expected tag instead of trusting list order, and report a missing repo as drift (renamed/removed changes the org shape) rather than failing the run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated path requires human/CODEOWNERS approval.
This PR adds .github/workflows/aamp-snapshot-check.yml, which matches the .github/workflows/** gated-path glob (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so the hard approval gate (decision-table row 2) is not satisfied and the PR cannot auto-approve regardless of how clean the diff is.
Iteration credit: both prior Medium findings in scripts/check-aamp-snapshot.cjs were resolved. gh() now returns null on 404 so a not-yet-created repo is reported as drift rather than crashing, and expectLatestTag now fetches per_page=100 and compares the full tag set instead of trusting tags[0] to be newest. No new findings in the delta. The escalation is purely the standing gated-path gate, not any code concern.
Resolution: a human/CODEOWNERS approval on the workflow file will lift the gate and let a subsequent review fall through to a normal (likely approve) outcome.
Escalation reasons
- Adds
.github/workflows/aamp-snapshot-check.yml(matches.github/workflows/**) under a hard, non-overridable approval gate;review_decisionisREVIEW_REQUIRED, notAPPROVED— human/CODEOWNERS review required before merge.
Why human review
- Adds gated path .github/workflows/aamp-snapshot-check.yml (matches .github/workflows/**) and review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required before merge.
- This PR touches a path under a hard, non-overridable approval gate (.github/workflows/aamp-snapshot-check.yml (added) matches
.github/workflows/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
Follow-ups from #6801:
aamp-snapshot-check.yml) compares the pinned snapshot inscripts/aamp-snapshot.jsonagainst the IABTechLab GitHub org and opens/updates a tracking issue on drift. Both the no-drift and drift paths were exercised against the live org (drift path via a deliberately wrong pinned tag).🤖 Generated with Claude Code