Skip to content

fix(test): isolate server unit tests from thread-pool env bleed #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 2 commits into from
Aug 23, 2026
Merged

fix(test): isolate server unit tests from thread-pool env bleed #6800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa632ca
fix(test): isolate server unit tests from thread-pool env bleed
garvitkaushik-123 Aug 23, 2026
72f38f2
fix(test): narrow server unit isolation change
bokelley Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/precommit-server-unit.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ function main() {
}

console.log(`Running ${plan.files.length} changed server unit test file(s).`);
return run('npm', ['exec', '--', 'vitest', 'run', ...plan.files]);
return run('npm', ['exec', '--', 'vitest', 'run', '--config', 'server/vitest.config.ts', ...plan.files]);
}

if (require.main === module) {
Expand Down
8 changes: 3 additions & 5 deletions server/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ export default defineConfig({
root: __dirname,
setupFiles: ['./tests/setup/revenue-tracking-env.ts'],
testTimeout: 30000,
// The module-level `pool` singleton in db/index.ts is shared across all
// tests in a worker. Running files in parallel lets one file's
// `afterAll(closeDatabase)` null the pool while a sibling file is
// mid-query, producing "Database not initialized" 500s that look like
// transient Anthropic flakes.
// Keep process isolation explicit so module-level singletons (database
// pool, WorkOS client, env-cached secrets) cannot bleed between files.
pool: 'forks',
fileParallelism: false,
},
});
Loading