Conversation
Contributor
Contributor
Public API surface diffNo change to the public API surface. ✅ |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When the CKF processes the measurement of the seed surface it skips the Kalman update and sets the position covariance of the track parameters from the measurement covariance:
For a 1-dimensional measurement
calibrated_measurement_covariancefills the unmeasured element V(1, 1) withstd::numeric_limits<scalar>::max(), and this value is then copied into the track covariance. The Kalman algebra then overflows in single precision on the next surface with the covariance becoming negative/infinite and every subsequent measurement gets χ² ≈ 0, so all candidates are accepted regardless of their residual.This affects any track whose seed measurement is 1D, i.e. strip-seeded tracking. Pixel-seeded tracks (2D seed measurement) should be unchanged.
The fix adds
measurement_selector::set_seed_measurement_covariance(), which assigns the measurement variance only to the coordinate(s) given by the measurement subspace and leaves the covariance of an unmeasured coordinate at the value it has from the seed parameter estimation.