Skip to content

refactor: ERROR Counting in Fatras - #6082

Open
katrinfriedrichs wants to merge 2 commits into
acts-project:mainfrom
katrinfriedrichs:FatrasERRORCounting
Open

katrinfriedrichs wants to merge 2 commits into
acts-project:mainfrom
katrinfriedrichs:FatrasERRORCounting

Conversation

@katrinfriedrichs

Copy link
Copy Markdown

Count the different ERROR Messages in Fatras

Count the different ERROR Messages in Fatras
@github-actions github-actions Bot added the Component - Examples Affects the Examples module label Sep 14, 2026
@github-actions github-actions Bot added this to the next milestone Sep 14, 2026

@LeaBaumann LeaBaumann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comment: The /// added for counting ERROR Messages comments describe the change history of the PR rather than what the members actually do. It'd be nice to have each one explain its own purpose individually rather than repeating the same note several times.

@sonarqubecloud

Copy link
Copy Markdown

Comment thread Examples/Algorithms/Fatras/include/ActsExamples/Fatras/FatrasSimulation.hpp Outdated
Comment thread Examples/Algorithms/Fatras/include/ActsExamples/Fatras/FatrasSimulation.hpp Outdated
Comment thread Examples/Algorithms/Fatras/include/ActsExamples/Fatras/FatrasSimulation.hpp Outdated
Comment thread Examples/Algorithms/Fatras/src/FatrasSimulation.cpp Outdated
Comment thread Examples/Algorithms/Fatras/src/FatrasSimulation.cpp Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Public API surface diff

No change to the public API surface. ✅

@github-actions

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for 0ed4f60

Full contents

physmon summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Examples Affects the Examples module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants