Skip to content

fix: undefined names in Python error paths #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: undefined names in Python error paths #6075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Detray/codegen/detray-sympy/detray_sympy/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import sys


def write_out_file_to_fp(code, output):
output.write("""// This file is part of the ACTS project.
//
Expand Down
1 change: 1 addition & 0 deletions Detray/tests/tools/python/options/common_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import argparse
import logging
import os
import sys
from datetime import datetime

Expand Down
2 changes: 1 addition & 1 deletion Detray/tests/tools/python/options/plotting_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def parse_plotting_options(args, logging):
os.mkdir(args.outdir, 0o755)

if args.output_format not in ["svg", "png", "pdf"]:
logging.error(f"Unknown output file format: {out_format}")
logging.error(f"Unknown output file format: {args.output_format}")
sys.exit(1)

return args.inputdir, args.outdir, args.output_format
2 changes: 1 addition & 1 deletion Detray/tests/tools/python/propagation_benchmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def __generate_benchmark_dict(

nvidia_smi.nvmlShutdown()

except NVMLError as e:
except nvidia_smi.NVMLError as e:
print(e)

except ModuleNotFoundError:
Expand Down
4 changes: 1 addition & 3 deletions Python/Examples/python/odd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,7 @@ def getOpenDataDetector(

if gen3:
if misaligned:
raise InvalidArgumentError(
"Gen3 ODD currently does not support misalignment"
)
raise ValueError("Gen3 ODD currently does not support misalignment")

oddConfig = acts.examples.dd4hep.OpenDataDetector.Config(
xmlFileNames=xml_files,
Expand Down
Loading