Skip to content

Grid and MultiAxis related naming #5601

Description

@andiwand

While working on the MultiAxis implementation I stumbled over a few potentially suboptimal names

  1. global bin and local bins
    • bin is actually an index - we could call it that way
    • global / local is a loaded term in ACTS and usually refers to different coordinate systems
    • my suggestion here would be something like flat index or linear index and multi index
  2. for Axis we use getX while for Grid we use x
  3. lower left edge / upper right edge
    • I believe this should rather be corner
  4. position vs point

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions