chore(tracing): move tracing-actix-web examples into workspace - #1423
Merged
Merged
Conversation
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the custom root span, OpenTelemetry, and request ID response header examples from
actix-extras/tracing-actix-web/examplesintotracing/.Register all three examples as workspace members, use workspace package settings and Tokio local runtime entry points, and update the run instructions. Use
tracing-actix-web0.7.22 as the minimum version with OpenTelemetry 0.32 support. Expose the OTLP port in the custom root span example's Jaeger command. The existing Mainmatter workshop is unchanged.The request ID example uses
middleware::from_fnandexamples_common::init_standard_logger(). The telemetry examples retain their custom subscribers for JSON console logs and OTLP export. They shut down their exporters withspawn_blockingso the local runtime can continue to drive I/O.Validation:
cargo clippy -p tracing-custom-root-span -p tracing-opentelemetry-example -p tracing-request-id-response-header --all-targets --all-features --offlinecargo build -p tracing-custom-root-span -p tracing-opentelemetry-example -p tracing-request-id-response-header --offlineTrace export to a running collector was not tested.
Companion source cleanup: actix/actix-extras#839. Merge this PR first so the updated documentation links resolve.