feat: add exempt-issues-with-open-linked-pr option - #1357
Open
somaz94 wants to merge 1 commit into
Open
Conversation
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Aug 4, 2026
somaz94
marked this pull request as ready for review
August 6, 2026 02:31
Author
|
This is out of draft now and ready for review. The five checks on To save you the risk of spending that approval on a red run, I re-validated locally today. The branch is already current with
Happy to rebase or adjust anything if you'd rather see the option shaped differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds an opt-in
exempt-issues-with-open-linked-proption. When enabled, an issue is left alone while an open pull request is linked to it in a way that will close it once merged. Work is still happening on the pull request, so the issue is not really inactive.Three notes on the design, since this touches the operations budget:
issues-processor.ts("this check is so far below because it cost one read operation"), the lookup only runs after every cheaper check has passed, so it is limited to issues that would otherwise be marked stale.operations-per-runbudget. There is a test asserting the lookup is never called when the option is off.closedByPullRequestsReferences(includeClosedPrs: false)field, which is the "Development" link aCloses #123creates. The REST timeline was the other option, but itscross-referencedevents also fire on a plain mention, which would exempt issues that merely got named in some pull request. GraphQL is reached through the existinggetOctokitclient, so there is no new dependency.If the query fails, the error is logged and the issue is processed as usual rather than being silently exempted.
Related issue:
Related to #1333.
Check list:
Validation, run locally on node 24:
npm run format-check,npm run lint,npm run buildall pass, anddist/rebuilds byte-identicallynpm testgoes from 29 suites / 1360 tests to 30 / 1366, no regressions