Repository navigation
Fix P2P simulator defaults and Sonnet 5 thinking - #57
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98a2ea2259
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2P sessions failed with a 404 when the default
sonnetalias selected the retiredclaude-sonnet-4-20250514. Withclaude-sonnet-5, replies failed because adaptive thinking returned aThinkingBlockwhere the parser expected text. Harbor Hub also forwards an omitted simulator override as an empty string, which previously bypassed the default.Treat unset and empty overrides as
sonnet, map that alias toclaude-sonnet-5, and passthinking={"type": "disabled"}for that model. Preserve the 512-token budget and explicit non-empty overrides. Add regressions for both P2P roles across unset, empty, alias, explicit Sonnet 5, and Haiku settings; update README and the CLAUDE.md simulator note.Validation:
uv run pytest -q --tb=short: 268 passed, 3 skipped, 1 deselected.src/andtests/.send_turnchecks onpa_t031_t031_o001_p01_p2p_payersucceeded with both unset and empty overrides.98a2ea2, with agent modelanthropic/claude-sonnet-5and the FAQ.env: four successful P2P turns, zero P2P tool errors, verifier reward 1.0. The empty-value follow-up at00eded2was verified by the separate live service check above.