Skip to content

fix: hide Legacy Savings GHO (stkGHO) card on sGHO page - #3114

Closed
sammdec wants to merge 2 commits into
mainfrom
fix/hide-legacy-sgho-card
Closed

sammdec wants to merge 2 commits into
mainfrom
fix/hide-legacy-sgho-card

Conversation

@sammdec

@sammdec sammdec commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

What

Removes the Legacy Savings GHO (stkGHO) card from the /sgho page.

Changes

  • pages/sgho.page.tsx: drop the <StkGhoCard /> branch from the sidebar slot.
    • Connected users now see only the Savings GHO (sGHO) card, which expands to fill the row (flex: 1).
    • Disconnected users still get the Your info connect-wallet prompt, unchanged.

StkGhoCard and the stkGHO modals (StkGhoMigrateModal, SavingsGhoDepositModal, SavingsGhoWithdrawModal) are left in the codebase and still mounted, but have no entry point from this page — so the card can be restored with a one-line change.

Temporarily removes the Legacy Savings GHO (stkGHO) card from /sgho.
Connected users now see only the sGHO card, which expands to fill the
row; the "Your info" connect prompt still renders when no wallet is
connected.

The StkGhoCard component and its modals are left in place so the card
can be restored with a one-line change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@odin-by-borg

odin-by-borg Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Mjolnir Security Review

New commits since last review at f080114.

Run Mjolnir Review


26 PRs reviewed · 1 finding

@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Sep 25, 2026 8:46pm UTC

Request Review

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.34 MB (-16 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 93.06 KB (🟢 -211 B) 1.43 MB
/dashboard 81.72 KB (🟢 -212 B) 1.42 MB
/governance/v3/proposal 84.49 KB (🟡 +1 B) 1.42 MB
/markets 54.22 KB (🟢 -213 B) 1.39 MB
/safety-module 55.62 KB (🟡 +177 B) 1.39 MB
/sgho 19.05 KB (🟢 -73.49 KB) 1.36 MB
/staking 31.45 KB (🟡 +1 B) 1.37 MB
/v3-migration 48.59 KB (🟢 -213 B) 1.39 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@sammdec sammdec closed this Sep 25, 2026

This branch was successfully deployed

1 active deployment
Preview — 16f4fef7 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant