Skip to content

ui: post uplift release qa - #3103

Merged
sammdec merged 3 commits into
mainfrom
abhijeet/post-uplift-release-qa-0
Sep 18, 2026
Merged

sammdec merged 3 commits into
mainfrom
abhijeet/post-uplift-release-qa-0

Conversation

@abjt14

@abjt14 abjt14 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor
Before After
Screenshot 2026-09-18 at 10 57 35 Screenshot 2026-09-18 at 10 58 02
Screenshot 2026-09-18 at 10 59 09 Screenshot 2026-09-18 at 10 59 25
Screenshot 2026-09-18 at 11 00 34 Screenshot 2026-09-18 at 11 00 48
Screenshot 2026-09-18 at 11 02 23 Screenshot 2026-09-18 at 11 02 34
Screenshot 2026-09-18 at 11 03 34 Screenshot 2026-09-18 at 11 04 10
Screenshot 2026-09-18 at 11 05 19 Screenshot 2026-09-18 at 11 05 37
Screenshot 2026-09-18 at 16 06 12 Screenshot 2026-09-18 at 16 06 24

- Replace the opengraph image with the new light-gradient asset. Renamed
  rather than overwritten so the social caches keyed on the old URL are
  busted on deploy.
- Point the Aave V4 header button and the market picker's external rows at
  the shared ArrowUpRightIcon, replacing heroicons' filled glyph. The header
  icon sizes through startIconSizeSx, since MUI's startIcon selector
  outranks an sx on the icon element.
- Drop the surface ring on the reserve header icon buttons in dark mode,
  matching the pill buttons: shadow-stroke-2 is a white hairline against the
  dark canvas.
- Bleed the token picker list to the modal's bottom edge and fade both ends
  into the surface. Each scrim covers the scroll area's own padding, so it
  is invisible at rest and only appears once rows pass beneath. The modal
  Paper now publishes --modal-surface so the gradients don't restate its
  light/dark pair.
- Match the staking dropdown options to the top-level nav links: buttonM
  type, fg-3 to fg-1 driven by the active class Link already applies, in
  place of the 400-weight ListItemText default.
- Retune buttonL to 15px with line-height normal and buttonM's negative
  tracking.
The favicon was switched on colour scheme in two places at once: a
prefers-color-scheme block inside favicon.svg, and a FaviconSwitcher
component rewriting the icon link href at runtime. Per design, only the
white-tile mark is wanted.

- favicon.svg keeps the white tile (#FCFCFC) and #716EF3 mark, with no
  media query. Display-P3 values retained alongside the sRGB fallback.
- Delete favicon-light.svg, favicon-dark.svg and the FaviconSwitcher
  component, along with its usage in AppGlobalStyles.
- Regenerate favicon-32/192/512.png, apple-touch-icon.png and favicon.ico
  from the new artwork; they were all still the dark tile. The rasters stay
  square and opaque rather than pre-rounded, since iOS and Android apply
  their own corner mask and transparent corners render as a black halo on
  iOS. favicon.ico keeps its original 16/32/48 PNG-payload structure.
@abjt14 abjt14 self-assigned this Sep 18, 2026
@odin-by-borg

odin-by-borg Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Mjolnir Security Review

New commits since last review at 76492eb.

Run Mjolnir Review


19 PRs reviewed · 1 finding

@vercel

vercel Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Sep 18, 2026 6:45am UTC

Request Review

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.34 MB (🟢 -171 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.82 KB (🟡 +4 B) 1.43 MB
/governance 43.08 KB (🟡 +4 B) 1.38 MB
/governance/v3/proposal 84.42 KB (🟡 +3 B) 1.42 MB
/history 32.57 KB (🟡 +4 B) 1.37 MB
/markets 53 KB (🟡 +4 B) 1.39 MB
/reserve-overview 38.9 KB (🟡 +54 B) 1.37 MB
/staking 31.51 KB (🟡 +4 B) 1.37 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@abjt14
abjt14 marked this pull request as ready for review September 18, 2026 01:56
@abjt14
abjt14 requested review from AGMASO and sammdec September 18, 2026 05:38
sammdec
sammdec previously approved these changes Sep 18, 2026
- The 1w/1m/6m/1y segments used buttonM (14px with a 20px line-height)
  inside a 24px shell, so the label was as tall as the pill it sat in.
  subheader2 keeps the 500 weight at 12px/16px. Scoped to this selector;
  label typography is owned per consumer, so the dashboard and tx-modal
  toggles are unaffected.
- The "Avg" pill was anchored 8px above the average line, but the series
  swings well above its own average and the peaks ran through it. Anchor it
  to the series maximum instead, so it clears every point regardless of the
  data, with a small manual offset for final placement. visx HtmlLabel is
  given no dx/dy, so both anchors default to 'end' and (x, y) is the pill's
  bottom-right corner.
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.34 MB (🟢 -170 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.82 KB (🟡 +4 B) 1.43 MB
/governance 43.08 KB (🟡 +4 B) 1.38 MB
/governance/v3/proposal 84.42 KB (🟡 +3 B) 1.42 MB
/history 32.57 KB (🟡 +4 B) 1.37 MB
/markets 53 KB (🟡 +4 B) 1.39 MB
/reserve-overview 38.9 KB (🟡 +54 B) 1.37 MB
/sgho 92.26 KB (🟡 +10 B) 1.43 MB
/staking 31.51 KB (🟡 +4 B) 1.37 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@abjt14
abjt14 requested a review from sammdec September 18, 2026 08:06
@sammdec
sammdec merged commit 2ff2437 into main Sep 18, 2026
27 checks passed
@sammdec
sammdec deleted the abhijeet/post-uplift-release-qa-0 branch September 18, 2026 10:45

This branch was successfully deployed

1 active deployment
Preview — 01a12d89 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants