feat: simpler role breakdown for risk management - #1355
Draft
Kogaroshi wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurator role breakdown
Carves risk management and emergency out of each configurator's single role, and renames the DOMAIN_ADMIN roles to DOMAIN_BASE.
addAsset,addAssetWithDecimals,updateLiquidityFee,updateFeeReceiver,updateFeeConfig,updateInterestRateStrategy,updateReinvestmentController,resetAssetCaps,addSpoke,addSpokeToAssets,updateSpokeActive,updateSpokeHalted,resetSpokeCapsupdateSpokeAddCap,updateSpokeDrawCap,updateSpokeRiskPremiumThreshold,updateSpokeCaps,updateInterestRateDatadeactivateAsset,haltAsset,deactivateSpoke,haltSpokeupdateReservePriceSource,addReserve,updatePaused,updateFrozen,updateBorrowable,updateReceiveSharesEnabled,updatePositionManagerupdateLiquidationTargetHealthFactor,updateHealthFactorForMaxBonus,updateLiquidationBonusFactor,updateLiquidationConfig,updateCollateralRisk,addCollateralFactor,updateCollateralFactor,addMaxLiquidationBonus,updateMaxLiquidationBonus,addLiquidationFee,updateLiquidationFee,addDynamicReserveConfig,updateDynamicReserveConfigpauseReserve,pauseAllReserves,freezeReserve,freezeAllReservesThe emergency selectors only ever move a target to a safer state and cannot revert it, so the role can be held by a faster-moving entity than the base role; the two-way flags (updateSpokeActive/updateSpokeHalted, updatePaused/updateFrozen) and the Hub cap resets stay on the base role, since only risk management can restore what they zero.