feat: permissioned spoke via modifier override - #1347
Open
AlbertoCentonze wants to merge 9 commits into
Open
Conversation
Marking the modifier virtual is the only change to Spoke, which keeps SpokeInstance deployed bytecode byte-identical to main. The gate check lives in an internal function so the override is not inlined per entry point (24,527 bytes at 750 runs).
SpokeInstance is back to exactly the main version. The gate authorization lives in an abstract PermissionedSpoke core, and the instance inherits SpokeInstance and PermissionedSpoke (diamond over Spoke), re-declaring the modifier override as required by the compiler. The modifier passes msg.sender and msg.data down instead of reading them in the internal check. SpokeInstance deployed bytecode stays byte-identical to main; PermissionedSpokeInstance is 24,535 bytes at 750 runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1334 that keeps the canonical SpokeInstance runtime bytecode unchanged by making onlyPositionManager virtual and overriding it for permissioned instances. The concrete instance repeats the modifier override to resolve the Spoke inheritance diamond. The gate applies to modifier-protected position actions; liquidations and direct _isPositionManager callers retain canonical behavior.