feat: Risk Stewards V4 Activation - #1180
Open
Kogaroshi wants to merge 8 commits into
Open
Conversation
DhairyaSethi
reviewed
Aug 7, 2026
|
|
||
| function _grantConfiguratorRoles() internal { | ||
| AaveV4Avalanche.ACCESS_MANAGER.grantRole({ | ||
| roleId: Roles.HUB_CONFIGURATOR_DOMAIN_ADMIN_ROLE, |
Member
There was a problem hiding this comment.
should we granularise this role now bc it doesnt need addAsset perm etc
Collaborator
Author
There was a problem hiding this comment.
I would do that with a dedicated AIP to granulize, update & all, for Spokes & Hubs
Member
There was a problem hiding this comment.
nobody owns these roles rn right (apart from pc and pc executor) so the role assignment should be fairly easy. it's fairly annoying to do role split everytime in a separate aip imo
Collaborator
Author
There was a problem hiding this comment.
let's have a 1st batch and split all methods needed for those Risk Stewards into 2 single roles (1 for Hub and 1 for Spoke), or let's go already with more granular 1 role per method type ?
Member
There was a problem hiding this comment.
i think let's group by requirement, we can probably keep pause/freeze in separate (bc that will be required to give to protocol council after hardening phase) and just freeze i think to proof of reserve robot of avax and then rest all in one clump. and this risk steward gets two roles: emergency & risk management
Contributor
There was a problem hiding this comment.
just freeze i think to proof of reserve robot of avax
Just want to mention that updateFrozen in the configurator allows both to freeze and unfreeze while proof of reserve robots just needs to freeze (no unfreeze) but we can add this extra constraint at the executor level.
🌈Test ResultsCompiling 524 files with Solc 0.8.28 Solc 0.8.28 finished in 135.93s Compiler run successful with warnings: Warning (2018): Function state mutability can be restricted to view --> lib/aave-helpers/src/dependencies/v4/Helpers.sol:42:3: | 42 | function _makeSigner() internal returns (uint256 privateKey, address signer) { | ^ (Relevant source part starts here and spans across multiple lines).Ran 26 tests for src/20260807_Multi_AaveV4RiskStewardsActivation/AaveV4Avalanche_AaveV4RiskStewardsActivation_20260807.t.sol:AaveV4Avalanche_AaveV4RiskStewardsActivation_20260807_Test
|
Collaborator
Author
|
New roles & breakdown reflected in aave/aave-v4#1332 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist: