Predict-Then-Debias code - #26
Merged
Merged
Conversation
tijana-zrnic
reviewed
Sep 4, 2025
tijana-zrnic
left a comment
tijana-zrnic
left a comment
Collaborator
There was a problem hiding this comment.
I just have one comment about the notebook. Everything else (ptd file, tests, etc) looks great.
Collaborator
There was a problem hiding this comment.
There are a few instances that say PTD is unbiased, in particular to refer to its validity. For example: "PTD is unbiased (the PTD confidence intervals contain the true coefficient)." Would you mind rewording these instances that say PTD is unbiased to refer to its validity, since PTD is not necessarily unbiased? Otherwise looks great and I'll merge!
Contributor
Author
There was a problem hiding this comment.
Thanks Tijana, I updated it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the Predict-Then-Debias python module (
ppi_py/ptd.py), a test file (tests/test_ptd.py), and a jupyter notebook showing how to use the ptd module with a tree cover dataset (examples/tree_cover_ptd.ipynb). We uploaded the tree cover dataset to Google Drive and added the link inppi_py/datasets/datasets.py.