Repository navigation
Back-to-back calls no longer inherit the previous call's name - #35
Merged
Merged
Conversation
A call that finished early and was followed by another in its slot (a quick debrief, say) was named after the first call, filed in its folder and given its invite. When Oatcake notices a call by itself and the event happening now has already been recorded, the recording is now just "Call". Everything else about picking the event is unchanged, as is starting a recording from the event itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eventHappening had gone in between ignoredEvent and the comment that describes it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a call finishes early and another starts while its calendar slot is still running (a quick debrief straight after, say), Oatcake noticed the second call and named it after the first: same title, same folder, same invite. So Who's who offered the first call's invitees for the debrief, and the sidebar showed two meetings with the same name.
Now, when Oatcake notices a call by itself and the event happening now already has a recording, the new recording is just "Call", with no event attached. This covers the "On a call?" notification's text, its Record button, and clicking it (New recording). An event counts as recorded if it was recorded since launch or still has a recording in Needs review.
Nothing else changes. The event is picked exactly as before, including the ten minutes before it starts. Starting a recording from the event itself (New recording, Upcoming) isn't affected.
Known trade-off: leave a call and rejoin the same meeting, and the second recording is "Call" rather than the meeting's title.
Tested
swift test: 96 tests pass, including a new one (callAfterAnEarlyFinish) for the old results when nothing's been recorded and "no event" once it has.Not tested
🤖 Generated with Claude Code