Skip to content

Several meetings dragged onto a folder all move, not just the top one - #31

Merged
tommusrhodus merged 1 commit into
trunkfrom
fix/drag-several-meetings
Nov 17, 2026
Merged

tommusrhodus merged 1 commit into
trunkfrom
fix/drag-several-meetings

Conversation

@tommusrhodus

Copy link
Copy Markdown
Contributor

Closes #23.

Dragging a selection of meetings from the meeting list brings one dropped item per meeting, but both drop targets (a folder in the sidebar, and the Meetings header) used only the first, so only the top one moved.

Both now move every dropped meeting with one toast ("Moved 2 meetings to Design reviews"). Meetings already in the target folder are left alone. If one can't be moved, the rest stop and the toast says how many went first, as Move to Trash does. A single meeting or folder dragged on its own behaves as before.

Tested

  • swift test: 90 tests pass (the change is in the app target, which has no unit tests).
  • In a built copy with real mouse drags: two meetings picked with click and ⌘-click and dragged onto a folder both moved ("Moved 2 meetings to Design reviews"); both dragged onto the Meetings header went back to the top level; a single meeting dragged to a folder and back still showed "Moved to …".

🤖 Generated with Claude Code

Dragging a selection of meetings from the list brings one item for each, but
both drop targets (a folder, and the Meetings header) moved only the first.
Every one is moved now, with one toast ("Moved 3 meetings to …"); one that
can't be moved stops the rest and the toast says how many went first, as Move
to Trash does. Meetings already in the folder are left alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@t51eng-poseidon

Copy link
Copy Markdown

🔱 Poseidon started reviewing this PR — central run.

@t51eng-poseidon t51eng-poseidon Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔱 Poseidon Review

Summary — Drops onto a sidebar folder or the Meetings header now move every dragged meeting instead of only the first; low risk, and the partial-failure handling matches the existing trash(_:) pattern.

Walkthrough

  • 🐛 Fix — Library.move(_:into:) takes an array of paths, skips ones already in the target, stops at the first failure, and shows one toast (Sources/Oatcake/Library.swift:L63-L81).
  • ♻️ Refactor — New droppedPaths(_:) helper used by both drop targets in Sources/Oatcake/SidebarView.swift.

No issues found on this pass.


ℹ️ Review info
  • Commit: 00db323
  • Files reviewed: Sources/Oatcake/Library.swift, Sources/Oatcake/SidebarView.swift (context: Sources/Oatcake/MeetingListView.swift, Sources/OatcakeCore/Meetings.swift)
  • Files skipped: none
  • Model: claude-opus-5-5

@tommusrhodus
tommusrhodus merged commit e78fab1 into trunk Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving multiple meetings to another folder

1 participant