Repository navigation
Several meetings dragged onto a folder all move, not just the top one - #31
Merged
Merged
Conversation
Dragging a selection of meetings from the list brings one item for each, but
both drop targets (a folder, and the Meetings header) moved only the first.
Every one is moved now, with one toast ("Moved 3 meetings to …"); one that
can't be moved stops the rest and the toast says how many went first, as Move
to Trash does. Meetings already in the folder are left alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🔱 Poseidon started reviewing this PR — central run. |
There was a problem hiding this comment.
🔱 Poseidon Review
Summary — Drops onto a sidebar folder or the Meetings header now move every dragged meeting instead of only the first; low risk, and the partial-failure handling matches the existing trash(_:) pattern.
Walkthrough
- 🐛 Fix —
Library.move(_:into:)takes an array of paths, skips ones already in the target, stops at the first failure, and shows one toast (Sources/Oatcake/Library.swift:L63-L81). - ♻️ Refactor — New
droppedPaths(_:)helper used by both drop targets inSources/Oatcake/SidebarView.swift.
No issues found on this pass.
ℹ️ Review info
- Commit: 00db323
- Files reviewed: Sources/Oatcake/Library.swift, Sources/Oatcake/SidebarView.swift (context: Sources/Oatcake/MeetingListView.swift, Sources/OatcakeCore/Meetings.swift)
- Files skipped: none
- Model: claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
Dragging a selection of meetings from the meeting list brings one dropped item per meeting, but both drop targets (a folder in the sidebar, and the Meetings header) used only the first, so only the top one moved.
Both now move every dropped meeting with one toast ("Moved 2 meetings to Design reviews"). Meetings already in the target folder are left alone. If one can't be moved, the rest stop and the toast says how many went first, as Move to Trash does. A single meeting or folder dragged on its own behaves as before.
Tested
swift test: 90 tests pass (the change is in the app target, which has no unit tests).🤖 Generated with Claude Code