Repository navigation
fix: start the capture guard's Node process only for calls it can block #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/bin/sh | ||
| # Plugin hooks run on every Bash and edit call in every project, so Node starts only when a rule in guard-capture.js could match. | ||
| input=$(cat) | ||
| # The guard reads only command and file_path, so the transcript path (always .jsonl), the cwd and an edit's text never count. A key quoted inside a JSON string is escaped, so only real keys match. | ||
| printf '%s' "$input" \ | ||
| | grep -oE '"(file_path|command)"[[:space:]]*:[[:space:]]*"([^"\\]|\\.)*"' \ | ||
| | grep -qiE 'capture|links|jsonl|kosh-reports' || exit 0 | ||
| if ! command -v node >/dev/null 2>&1; then | ||
| echo "Blocked: kosh's capture guard needs node on PATH to check this call." >&2 | ||
| exit 2 | ||
| fi | ||
| printf '%s' "$input" | node "$(dirname "$0")/guard-capture.js" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pre-filter greps the whole
tool_input, so anEdit/Write/MultiEditwhosecontent,old_stringornew_stringcontainslinks,captureorjsonlgets through to Node.guard-capture.jsnever reads those fields: for edit tools it only testsargs.file_path(hooks/guard-capture.js:60). For the users this PR targets (nonodeon the hook's PATH), that call now hitsexit 2. So in any project, even with kosh unused, Claude can't write a README, HTML template or JS file that mentions "links" or "capture". Before this PR the same call went through with a non-blocking error; now it's a hard block. Match only the fields the guard reads, e.g.grep -oE '"(file_path|command)"[[:space:]]*:[[:space:]]*"([^"\\]|\\.)*"' | grep -qiE 'capture|links|jsonl|kosh-reports' || exit 0. That is safe for the same reason the existingsedis: a key quoted inside a JSON string is always escaped.🤖 Fix prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d5443ab