Skip to content

examples/suspense: buffer the slot channel so producers can't leak #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

examples/suspense: buffer the slot channel so producers can't leak #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/suspense/main.templ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import (
func main() {
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
// Create a channel to send deferred component renders to the template.
data := make(chan SlotContents)
// Buffer for the known 3 slots so a goroutine never blocks on send if
// the client disconnects before the template finishes reading.
data := make(chan SlotContents, 3)

// We know there are 3 slots, so start a WaitGroup.
var wg sync.WaitGroup
Expand Down
4 changes: 3 additions & 1 deletion examples/suspense/main_templ.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.