Skip to content

Fix JavaScript function name validation #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akfaew wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −1
Open

Fix JavaScript function name validation #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions js_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,42 @@ func TestJSFunctionNameRegexp(t *testing.T) {
input: "alert",
expected: true,
},
{
input: "a",
expected: true,
},
{
input: "$",
expected: true,
},
{
input: "_",
expected: true,
},
{
input: "$._",
expected: true,
},
{
input: "console.log('hello')",
expected: false,
},
{
input: "console.",
expected: false,
},
{
input: ".log",
expected: false,
},
{
input: "console..log",
expected: false,
},
{
input: "1alert",
expected: false,
},
{
input: "</script><div>Hello</div><script>",
expected: false,
Expand Down
2 changes: 1 addition & 1 deletion scripttemplate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,4 @@ func jsonEncodeParam(param any) string {
}

// isValidJSFunctionName returns true if the given string is a valid JavaScript function name, e.g. console.log, alert, etc.
var jsFunctionName = regexp.MustCompile(`^([$_a-zA-Z][$_a-zA-Z0-9]+\.?)+$`)
var jsFunctionName = regexp.MustCompile(`^[$_a-zA-Z][$_a-zA-Z0-9]*(\.[$_a-zA-Z][$_a-zA-Z0-9]*)*$`)