Skip to content

fix: ensure goroutines never leak in Suspense example #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scrhartley wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure goroutines never leak in Suspense example #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions examples/suspense/main.templ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ import (

func main() {
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
expectedSlots := 3

// Create a channel to send deferred component renders to the template.
data := make(chan SlotContents)
// Use a buffered channel so the goroutines can finish without being blocked.
data := make(chan SlotContents, expectedSlots)

// We know there are 3 slots, so start a WaitGroup.
// We know the number of slots, so start a WaitGroup.
var wg sync.WaitGroup
wg.Add(3)
wg.Add(expectedSlots)

// Start the async processes.
// Sidebar.
Expand Down
15 changes: 9 additions & 6 deletions examples/suspense/main_templ.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading