Update CMakeLists.txt for OpenBSD - #5044
Closed
ovi-vansid wants to merge 1 commit into
Closed
Conversation
Added OpenBSD as additional target distro and added condition for /tmp as default cache path for OpenBSD.
Author
|
Wasn't sure if I should use MATCHES or STREQUAL (I see both are used for distro comparisons). |
Member
|
MATCHES is for using a regular expression. So strequals is probably what you want although either will likely do. I think this can be simplified instead of adding the extra if STREQUALS OpenBSD, at the initial setting of ZM_PATH_MAP, I think you can just add it to the area down below that you have added. So all the OpenBSD stuff is in one place. |
Author
|
I'll group all of these together and change the comparisons to STREQUALS. You can reject this PR and I'll submit another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added OpenBSD as additional target distro and added condition for /tmp as default cache path for OpenBSD.