Fix: Rename from onerror to onerrorGo2rtc in VideoRTC - #5027
Open
IgorA100 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the reported TypeError: this.onerror is not a function in the WebSocket error handler for the Go2RTC/WebRTC streaming path by renaming the handler to avoid colliding with the DOM’s onerror event-handler property on HTMLElement.
Changes:
- Rename
VideoRTC.onerrortoVideoRTC.onerrorGo2rtcand update the WebSocket"error"event listener to call the new method. - Update
VideoStreamto overrideonerrorGo2rtcand callsuper.onerrorGo2rtc(ev).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/js/video-stream.js | Renames the overridden WebSocket error handler to onerrorGo2rtc and updates the super call accordingly. |
| web/js/video-rtc.js | Updates WebSocket "error" event wiring and renames the base handler method to onerrorGo2rtc. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix #5025