cmake: specify CMAKE_* variables as CACHE - #992
Open
dacav wants to merge 1 commit into
Open
Conversation
While keeping current default, honours the user choices.
akallabeth
reviewed
Jul 17, 2026
| set(CMAKE_COLOR_MAKEFILE OFF) | ||
| set(CMAKE_VERBOSE_MAKEFILE ON) | ||
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | ||
| set(CMAKE_COLOR_MAKEFILE OFF CACHE BOOL "Color output during build") |
There was a problem hiding this comment.
- why leave out
CMAKE_POSITION_INDEPENDENT_CODE? - keeping style with below,
optionwould be the better choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While keeping current default, honours the user choices.