Skip to content

oath: add rename instruction to protocol - #294

Open
klali wants to merge 1 commit into
masterfrom
oath_rename
Open

oath: add rename instruction to protocol#294
klali wants to merge 1 commit into
masterfrom
oath_rename

Conversation

@klali

@klali klali commented Apr 1, 2020

Copy link
Copy Markdown
Member

No description provided.

@klali
klali requested a review from dainnilsson April 1, 2020 08:42
Comment thread content/OATH/YKOATH_Protocol.adoc
Comment thread content/OATH/YKOATH_Protocol.adoc

@imakhalova imakhalova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve copy-paste mistakes.
Do you know why this adoc doesn't look good after DELETE operation on Github view? May be it requires couple spaces to understand formatting?

@klali

klali commented Apr 9, 2020

Copy link
Copy Markdown
Member Author

I don't think there's any errors in this. Please verify with a device how it behaves.

I don't know what breaks that part of the formatting, but it's unrelated to this PR. :)

@imakhalova imakhalova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that works on device.
Although errors were a little bit unexpected and need to be worked around on client side.
And renaming without any change to an account also gives an error.
Providing empty name - works without error.

StarGate01 added a commit to VivoKey/apex-totp that referenced this pull request Dec 21, 2022
See also: Yubico/developers.yubico.com#294

Co-authored-by: Klas Lindfors <klas@yubico.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants