oath: add rename instruction to protocol - #294
Open
klali wants to merge 1 commit into
Open
Conversation
imakhalova
reviewed
Apr 9, 2020
imakhalova
reviewed
Apr 9, 2020
imakhalova
suggested changes
Apr 9, 2020
imakhalova
left a comment
There was a problem hiding this comment.
Please resolve copy-paste mistakes.
Do you know why this adoc doesn't look good after DELETE operation on Github view? May be it requires couple spaces to understand formatting?
Member
Author
|
I don't think there's any errors in this. Please verify with a device how it behaves. I don't know what breaks that part of the formatting, but it's unrelated to this PR. :) |
imakhalova
approved these changes
Apr 9, 2020
imakhalova
left a comment
There was a problem hiding this comment.
Verified that works on device.
Although errors were a little bit unexpected and need to be worked around on client side.
And renaming without any change to an account also gives an error.
Providing empty name - works without error.
StarGate01
added a commit
to VivoKey/apex-totp
that referenced
this pull request
Dec 21, 2022
See also: Yubico/developers.yubico.com#294 Co-authored-by: Klas Lindfors <klas@yubico.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.